Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dynamic confirmation process #1374

Open
ripienaar opened this issue Aug 24, 2021 · 0 comments
Open

Add a dynamic confirmation process #1374

ripienaar opened this issue Aug 24, 2021 · 0 comments

Comments

@ripienaar
Copy link
Member

ripienaar commented Aug 24, 2021

Some thoughts based on https://rachelbythebay.com/w/2020/10/26/num/

The question here is what's the threshold to prompt vs just go ahead? I think we can add a DDL annotation per action, something like "confirm": true, "confirm_prompt": "This will restart {{count}} machines"", in the choria config then we set the specific threshold of 10, 100 or 1000. Over that threshold the prompt is activated if there is a TTY involved

We might also add a option to prompt on unfiltered, something like we have in package app:

https://github.com/choria-plugins/package-agent/blob/31fde418a7d4b160b042c97e49c6274b31094096/application/package.rb#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant