Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORIA_SRV_DOMAIN not getting used from environment variable #2112

Open
treydock opened this issue Feb 8, 2024 · 0 comments
Open

CHORIA_SRV_DOMAIN not getting used from environment variable #2112

treydock opened this issue Feb 8, 2024 · 0 comments

Comments

@treydock
Copy link
Contributor

treydock commented Feb 8, 2024

Now that Choria 0.28.0 is released trying to validate #2097

$ export CHORIA_SRV_DOMAIN=dev.company.net
$ choria tool config plugin.choria.srv_domain
<SNIP>
Configuration item: plugin.choria.srv_domain

║        Value: <GCP project domain, not dev.company.net>
║          URL: https://choria.io/docs/deployment/dns/
║    Data Type: string
║  Environment: CHORIA_SRV_DOMAIN
║
║ The domain to use for SRV records, defaults to the domain the
║ server FQDN is in
╙─

It looks like the lack of a default is preventing this code path from getting used. Will come up with a simple fix.
treydock added a commit to treydock/go-choria that referenced this issue Feb 8, 2024
@treydock
(choria-io#2112) Ensure CHORIA_SRV_DOMAIN is actually getting used
b8aa52f 
The logic to pull config defaults from an environment variable is only used when a config has a default.
This adds empty string default for SRV domain which will trigger the logic to pull a default value also from the CHORIA_SRV_DOMAIN environment variable.
treydock added a commit to treydock/go-choria that referenced this issue Feb 8, 2024
@treydock
(choria-io#2112) Ensure CHORIA_SRV_DOMAIN is actually getting used
dccf403 
The logic to pull config defaults from an environment variable is only used when a config has a default.
This adds empty string default for SRV domain which will trigger the logic to pull a default value also from the CHORIA_SRV_DOMAIN environment variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@treydock