From 0666f55ba80bf17520d5e5a55765ea7e188153ff Mon Sep 17 00:00:00 2001
From: chris48s <chris.shaw480@gmail.com>
Date: Sat, 11 Aug 2018 22:57:54 +0100
Subject: [PATCH] remove tests we don't need

this case is covered in base class tests added in #1890
---
 services/apm/apm.tester.js         |  5 -----
 services/cdnjs/cdnjs.tester.js     | 14 --------------
 services/clojars/clojars.tester.js | 14 --------------
 services/gem/gem.tester.js         | 30 ------------------------------
 4 files changed, 63 deletions(-)

diff --git a/services/apm/apm.tester.js b/services/apm/apm.tester.js
index 78cb27c09e118..779a204e5fb21 100644
--- a/services/apm/apm.tester.js
+++ b/services/apm/apm.tester.js
@@ -33,11 +33,6 @@ t.create('License | Package not found')
   .get('/l/notapackage.json')
   .expectJSON({ name: 'license', value: 'package not found' })
 
-t.create('Connection error')
-  .get('/v/vim-mode.json')
-  .networkOff()
-  .expectJSON({ name: 'apm', value: 'inaccessible' })
-
 t.create('Invalid version')
   .get('/dm/vim-mode.json')
   .intercept(nock =>
diff --git a/services/cdnjs/cdnjs.tester.js b/services/cdnjs/cdnjs.tester.js
index 0299199952315..5bdf27f2f2d64 100644
--- a/services/cdnjs/cdnjs.tester.js
+++ b/services/cdnjs/cdnjs.tester.js
@@ -19,17 +19,3 @@ t.create('cdnjs (valid)')
 t.create('cdnjs (not found)')
   .get('/v/not-a-library.json')
   .expectJSON({ name: 'cdnjs', value: 'not found' })
-
-t.create('cdnjs (connection error)')
-  .get('/v/jquery.json')
-  .networkOff()
-  .expectJSON({ name: 'cdnjs', value: 'inaccessible' })
-
-t.create('cdnjs (error response)')
-  .get('/v/jquery.json')
-  .intercept(nock =>
-    nock('https://api.cdnjs.com')
-      .get('/libraries/jquery?fields=version')
-      .reply(500, '{"error":"oh noes!!"}')
-  )
-  .expectJSON({ name: 'cdnjs', value: 'invalid' })
diff --git a/services/clojars/clojars.tester.js b/services/clojars/clojars.tester.js
index cf91fee04a962..034adddc11c63 100644
--- a/services/clojars/clojars.tester.js
+++ b/services/clojars/clojars.tester.js
@@ -18,17 +18,3 @@ t.create('clojars (valid)')
 t.create('clojars (not found)')
   .get('/v/not-a-package.json')
   .expectJSON({ name: 'clojars', value: 'not found' })
-
-t.create('clojars (connection error)')
-  .get('/v/jquery.json')
-  .networkOff()
-  .expectJSON({ name: 'clojars', value: 'inaccessible' })
-
-t.create('clojars (error response)')
-  .get('/v/prismic.json')
-  .intercept(nock =>
-    nock('https://clojars.org')
-      .get('/prismic/latest-version.json')
-      .reply(500, '{"error":"oh noes!!"}')
-  )
-  .expectJSON({ name: 'clojars', value: 'invalid' })
diff --git a/services/gem/gem.tester.js b/services/gem/gem.tester.js
index 6ee7d62249b27..b2e2413d2a43b 100644
--- a/services/gem/gem.tester.js
+++ b/services/gem/gem.tester.js
@@ -30,11 +30,6 @@ t.create('version (not found)')
   .get('/v/not-a-package.json')
   .expectJSON({ name: 'gem', value: 'not found' })
 
-t.create('version (connection error)')
-  .get('/v/formatador.json')
-  .networkOff()
-  .expectJSON({ name: 'gem', value: 'inaccessible' })
-
 // downloads endpoints
 
 // total downloads
@@ -51,11 +46,6 @@ t.create('total downloads (not found)')
   .get('/dt/not-a-package.json')
   .expectJSON({ name: 'downloads', value: 'not found' })
 
-t.create('total downloads (connection error)')
-  .get('/dt/rails.json')
-  .networkOff()
-  .expectJSON({ name: 'downloads', value: 'inaccessible' })
-
 // version downloads
 t.create('version downloads (valid, stable version)')
   .get('/dv/rails/stable.json')
@@ -87,11 +77,6 @@ t.create('version downloads (valid package, version not specified)')
   .get('/dv/rails.json')
   .expectJSON({ name: 'downloads', value: 'invalid' })
 
-t.create('version downloads (connection error)')
-  .get('/dv/rails/4.1.0.json')
-  .networkOff()
-  .expectJSON({ name: 'downloads', value: 'inaccessible' })
-
 // latest version downloads
 t.create('latest version downloads (valid)')
   .get('/dtv/rails.json')
@@ -106,11 +91,6 @@ t.create('latest version downloads (not found)')
   .get('/dtv/not-a-package.json')
   .expectJSON({ name: 'downloads', value: 'not found' })
 
-t.create('latest version downloads (connection error)')
-  .get('/dtv/rails.json')
-  .networkOff()
-  .expectJSON({ name: 'downloads', value: 'inaccessible' })
-
 // users endpoint
 
 t.create('users (valid)')
@@ -126,11 +106,6 @@ t.create('users (not found)')
   .get('/u/not-a-package.json')
   .expectJSON({ name: 'gems', value: 'not found' })
 
-t.create('users (connection error)')
-  .get('/u/raphink.json')
-  .networkOff()
-  .expectJSON({ name: 'gems', value: 'inaccessible' })
-
 // rank endpoint
 
 t.create('total rank (valid)')
@@ -154,8 +129,3 @@ t.create('daily rank (valid)')
 t.create('rank (not found)')
   .get('/rt/not-a-package.json')
   .expectJSON({ name: 'rank', value: 'not found' })
-
-t.create('rank (connection error)')
-  .get('/rt/rspec-puppet-facts.json')
-  .networkOff()
-  .expectJSON({ name: 'rank', value: 'inaccessible' })