From 7145b481e0ca2cc0754fb9e5b84b2ab759235e4a Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Wed, 10 Apr 2024 18:01:18 -0700 Subject: [PATCH] deps: Upgrade @react-native-async-storage/async-storage to 1.23.1 (latest) Changelog: https://github.com/react-native-async-storage/async-storage/releases This new version has a "privacy manifest", which should help us toward #5847. For why this upgrade is unlikely to break things, see: https://github.com/zulip/zulip-mobile/pull/5309#discussion_r847620787 For why the version was constrained with ~ instead of ^ see 47b7eadfa, an Expo SDK upgrade: [T]he `expo upgrade` command went through a phase it described as "Updating packages to compatible versions (where known)," and that changed several of our dependency ranges, even of non-Expo things. It would actually be better to remove the dependency entirely. It's our legacy way of storing data on the device, and we have a migration to the new way that's now been active for over two years (see caf3bf999). The proportion of our users who still benefit from what this dependency offers will be vanishingly small at this point. But I'm not totally comfortable removing it without more careful thought than we have time for right now in this legacy codebase. (One step we'd want to consider, if doing that, is adding and releasing a migration to clear out the contents of the legacy storage.) Tested on my iPhone and on the office Android device, on both a first and a subsequent startup of the app. No crashes or errors observed. Related: #5847 --- ios/Podfile.lock | 4 ++-- package.json | 2 +- yarn.lock | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ios/Podfile.lock b/ios/Podfile.lock index 6cd424c759c..ff5c09ec9d9 100644 --- a/ios/Podfile.lock +++ b/ios/Podfile.lock @@ -330,7 +330,7 @@ PODS: - React-perflogger (= 0.68.7) - rn-fetch-blob (0.11.2): - React-Core - - RNCAsyncStorage (1.17.12): + - RNCAsyncStorage (1.23.1): - React-Core - RNCClipboard (1.13.2): - React-Core @@ -636,7 +636,7 @@ SPEC CHECKSUMS: React-runtimeexecutor: 18932e685b4893be88d1efc18f5f8ca1c9cd39d8 ReactCommon: 29bb6fad3242e30e9d049bc9d592736fa3da9e50 rn-fetch-blob: f525a73a78df9ed5d35e67ea65e79d53c15255bc - RNCAsyncStorage: 09fc8595e6d6f6d5abf16b23a56b257d9c6b7c5b + RNCAsyncStorage: 826b603ae9c0f88b5ac4e956801f755109fa4d5c RNCClipboard: 60fed4b71560d7bfe40e9d35dea9762b024da86d RNCMaskedView: 0e1bc4bfa8365eba5fbbb71e07fbdc0555249489 RNCPushNotificationIOS: 64218f3c776c03d7408284a819b2abfda1834bc8 diff --git a/package.json b/package.json index 9e30fe2beb7..5484b1ad0b6 100644 --- a/package.json +++ b/package.json @@ -23,7 +23,7 @@ }, "dependencies": { "@expo/react-native-action-sheet": "^3.8.0", - "@react-native-async-storage/async-storage": "~1.17.3", + "@react-native-async-storage/async-storage": "^1.23.1", "@react-native-camera-roll/camera-roll": "^5.0.4 <5.3.0", "@react-native-clipboard/clipboard": "^1.11.1", "@react-native-community/masked-view": "^0.1.10", diff --git a/yarn.lock b/yarn.lock index 238a791eaac..a0b20194a6b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2136,10 +2136,10 @@ resolved "https://registry.yarnpkg.com/@pkgjs/parseargs/-/parseargs-0.11.0.tgz#a77ea742fab25775145434eb1d2328cf5013ac33" integrity sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg== -"@react-native-async-storage/async-storage@~1.17.3": - version "1.17.12" - resolved "https://registry.yarnpkg.com/@react-native-async-storage/async-storage/-/async-storage-1.17.12.tgz#a39e4df5b06795ce49b2ca5b7ca9b8faadf8e621" - integrity sha512-BXg4OxFdjPTRt+8MvN6jz4muq0/2zII3s7HeT/11e4Zeh3WCgk/BleLzUcDfVqF3OzFHUqEkSrb76d6Ndjd/Nw== +"@react-native-async-storage/async-storage@^1.23.1": + version "1.23.1" + resolved "https://registry.yarnpkg.com/@react-native-async-storage/async-storage/-/async-storage-1.23.1.tgz#cad3cd4fab7dacfe9838dce6ecb352f79150c883" + integrity sha512-Qd2kQ3yi6Y3+AcUlrHxSLlnBvpdCEMVGFlVBneVOjaFaPU61g1huc38g339ysXspwY1QZA2aNhrk/KlHGO+ewA== dependencies: merge-options "^3.0.4"