From d8f0c67d2e18e5d49295e019e4df23e527429162 Mon Sep 17 00:00:00 2001 From: Chris Darroch Date: Sat, 15 Aug 2020 22:45:44 -0700 Subject: [PATCH] remove leftover NeedsServiceVerb test category In PR #216 extensive work was done to remove some of the repository registry support of the Scalar service, and many tests no longer required the MacTODO.NeedsServiceVerb category flag and could be successfully executed on the Mac. One test which appears to have been missed was the SecondCloneSucceedsWithMissingTrees() test in SharedCacheTests.cs; however, it also succeeds on the Mac now and so we can remove this functional test category entirely. --- Scalar.FunctionalTests/Categories.cs | 3 --- Scalar.FunctionalTests/Program.cs | 1 - .../Tests/MultiEnlistmentTests/SharedCacheTests.cs | 1 - 3 files changed, 5 deletions(-) diff --git a/Scalar.FunctionalTests/Categories.cs b/Scalar.FunctionalTests/Categories.cs index 4d9ccd0e7cf..723ef6ccaca 100644 --- a/Scalar.FunctionalTests/Categories.cs +++ b/Scalar.FunctionalTests/Categories.cs @@ -16,9 +16,6 @@ public static class MacTODO { // Tests that require Config to be built public const string NeedsScalarConfig = "NeedsConfig"; - - // Tests that require Scalar Service - public const string NeedsServiceVerb = "NeedsServiceVerb"; } public static class NonWindowsTODO diff --git a/Scalar.FunctionalTests/Program.cs b/Scalar.FunctionalTests/Program.cs index f635197b083..5a0690dd807 100644 --- a/Scalar.FunctionalTests/Program.cs +++ b/Scalar.FunctionalTests/Program.cs @@ -89,7 +89,6 @@ public static void Main(string[] args) if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) { excludeCategories.Add(Categories.MacTODO.NeedsScalarConfig); - excludeCategories.Add(Categories.MacTODO.NeedsServiceVerb); excludeCategories.Add(Categories.NonWindowsTODO.TestNeedsToLockFile); excludeCategories.Add(Categories.WindowsOnly); } diff --git a/Scalar.FunctionalTests/Tests/MultiEnlistmentTests/SharedCacheTests.cs b/Scalar.FunctionalTests/Tests/MultiEnlistmentTests/SharedCacheTests.cs index 9eee4f09564..14bcffed1bb 100644 --- a/Scalar.FunctionalTests/Tests/MultiEnlistmentTests/SharedCacheTests.cs +++ b/Scalar.FunctionalTests/Tests/MultiEnlistmentTests/SharedCacheTests.cs @@ -91,7 +91,6 @@ public void GitObjectsRecreatedWhenDownloadingObjects() } [TestCase] - [Category(Categories.MacTODO.NeedsServiceVerb)] public void SecondCloneSucceedsWithMissingTrees() { string newCachePath = Path.Combine(this.localCacheParentPath, ".customScalarCache2");