Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow num to be buffer #16

Open
kumavis opened this issue Dec 6, 2016 · 3 comments
Open

allow num to be buffer #16

kumavis opened this issue Dec 6, 2016 · 3 comments

Comments

@kumavis
Copy link

kumavis commented Dec 6, 2016

I would like to varint.encode(bufferInt)

@kumavis
Copy link
Author

kumavis commented Dec 6, 2016

I have to do this silly dance to go buffer num -> buffer varint:

new Buffer(varint.encode(bufferToNumber(pfx)))
function bufferToNumber(buf){
  return parseInt(buf.toString('hex'),16)
}

@mafintosh
Copy link
Collaborator

I'm unsure what you mean. Could explain it in a bit more detail?
I personally do this to encode to a buffer

var buf = new Buffer(varint.encodingLength(num))
varint.encode(num, buf)

@kumavis
Copy link
Author

kumavis commented Dec 6, 2016

I would like to encode from buffer. of course this can be solved in user space, but i thought i would make the feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants