Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with neovim's :terminal #187

Closed
shiro opened this issue Nov 9, 2017 · 9 comments
Closed

Does not work with neovim's :terminal #187

shiro opened this issue Nov 9, 2017 · 9 comments

Comments

@shiro
Copy link

shiro commented Nov 9, 2017

If you start a terminal inside of neovim (with :terminal) it becomes impossible to switch the pane. (both inside vim and tmux).
The funny part is: it does seem to work again after opening vim inside said terminal ^^

@christoomey
Copy link
Owner

I'm not a neovim user so I've not been able to test this myself, but this PR adds bindings for neovim's terminal mode. Can you check that out, and if it works for you let us know as a data point around that functionality?

@blueyed
Copy link
Collaborator

blueyed commented Nov 10, 2017

See #111 and #129 - i.e. we've tried it already.. ;)

@bangn
Copy link

bangn commented Nov 28, 2017

I got same problem. Cannot navigate in neovim however it works with vim.

Recently migrate to Ubuntu Artful with tmux 2.6, nvim 0.2.1 and using i3-sensible-termial.

It used to work on iTerm and tmux with same config (In macOs Sierra).

@damnskippy
Copy link

@bangn when you "it works with vim", are you saying it works with vim terminal?
The reason I'm asking is because this doesn't work for me and was wondering whether vim's terminal is supported or not. Thanks.

@bangn
Copy link

bangn commented Dec 29, 2017

Hi @damnskippy,

Im not fully understand what you meant by vim terminal. However, when I used vim, gtk-terminal and tmux, vim-tmux-navigator works for me. Neovim will not

Hope it helps

Cheers
Bang

@damnskippy
Copy link

@bangn @christoomey
No I was just wondering about something like this to navigate out of a native vim terminal.

if has('terminal')
    tmap <c-k> <c-w>:TmuxNavigateUp<cr>
    tmap <c-j> <c-w>:TmuxNavigateDown<cr>
    tmap <c-h> <c-w>:TmuxNavigateLeft<cr>
    tmap <c-l> <c-w>:TmuxNavigateRight<cr>
endif

I already have the above in my vimrc and works great, so I'm all set; but just wondering if it makes sense to integrate into this plugin "natively", but I also see how it is out of scope in some ways.

@christoomey
Copy link
Owner

I believe we've avoided adding (actually added and then subsequently removed) the mappings as part of the core plugin as they interfere with fzf.vim functionality (see #128).

@bangn
Copy link

bangn commented Jan 7, 2018

Got it working by changing the regex. I think because I installed neovim via nix package manager.

Credit to: https://mendo.zone/fun/neovim-setup-haskell/

@christoomey
Copy link
Owner

Closing this in favor of #172 where I'd like to collect any conversations around terminal mode mappings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants