New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cond_unlock for keys that do not fit in a single unlock message #160

Merged

christoph2 merged 2 commits into christoph2:master from danielhrisca:master

Feb 29, 2024

Contributor

danielhrisca commented Feb 29, 2024

The UNLOCK commands must contain the remaining length of the key bytes.

MAX_CTO = 8 bytes (CAN)
TotalLengthOf(seed) = 19 bytes
TotalLengthOf(key) = 10 bytes
Seed = 99 88 77 66 55 44 33 22 11 00 11 22 33 44 55 66 77 88 99
Key = 98 76 54 32 10 01 23 45 67 89

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

danielhrisca added 2 commits

February 29, 2024 14:16


          fix cond_unlock for keys that do not fit in a single unlock message

60f0c59


          improve getting the seed in cond_unlock

f6d68e2

christoph2 merged commit 89add6b into christoph2:master

17 of 19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet