diff --git a/rust/worker/src/blockstore/arrow/blockfile.rs b/rust/worker/src/blockstore/arrow/blockfile.rs index 26089f094bc..3a118cdd81e 100644 --- a/rust/worker/src/blockstore/arrow/blockfile.rs +++ b/rust/worker/src/blockstore/arrow/blockfile.rs @@ -284,7 +284,7 @@ impl<'me, K: ArrowReadableKey<'me> + Into, V: ArrowReadableValue<'me join_all(futures).await; } - pub(crate) async fn load_blocks_for_keys(&self, prefixes: &Vec<&str>, keys: &Vec) -> () { + pub(crate) async fn load_blocks_for_keys(&self, prefixes: Vec<&str>, keys: Vec) -> () { let mut composite_keys = Vec::new(); let mut prefix_iter = prefixes.iter(); let mut key_iter = keys.iter(); @@ -294,9 +294,7 @@ impl<'me, K: ArrowReadableKey<'me> + Into, V: ArrowReadableValue<'me composite_keys.push(composite_key); } } - let target_block_ids = self - .sparse_index - .get_all_target_block_ids(&mut composite_keys); + let target_block_ids = self.sparse_index.get_all_target_block_ids(composite_keys); self.load_blocks(target_block_ids).await; } diff --git a/rust/worker/src/blockstore/arrow/sparse_index.rs b/rust/worker/src/blockstore/arrow/sparse_index.rs index 652b6489064..294916c515d 100644 --- a/rust/worker/src/blockstore/arrow/sparse_index.rs +++ b/rust/worker/src/blockstore/arrow/sparse_index.rs @@ -99,10 +99,7 @@ impl SparseIndex { reverse.insert(block_id, SparseIndexDelimiter::Start); } - pub(super) fn get_all_target_block_ids( - &self, - search_keys: &mut Vec, - ) -> Vec { + pub(super) fn get_all_target_block_ids(&self, mut search_keys: Vec) -> Vec { // Sort so that we can search in one iteration. search_keys.sort(); let mut result_uuids = Vec::new(); diff --git a/rust/worker/src/blockstore/types.rs b/rust/worker/src/blockstore/types.rs index 4d07341de92..12a661b085b 100644 --- a/rust/worker/src/blockstore/types.rs +++ b/rust/worker/src/blockstore/types.rs @@ -351,7 +351,7 @@ impl< } } - pub(crate) async fn load_blocks_for_keys(&self, prefixes: &Vec<&str>, keys: &Vec) -> () { + pub(crate) async fn load_blocks_for_keys(&self, prefixes: Vec<&str>, keys: Vec) -> () { match self { BlockfileReader::MemoryBlockfileReader(reader) => unimplemented!(), BlockfileReader::ArrowBlockfileReader(reader) => { diff --git a/rust/worker/src/segment/record_segment.rs b/rust/worker/src/segment/record_segment.rs index 84a6bc4f619..3ef19df1641 100644 --- a/rust/worker/src/segment/record_segment.rs +++ b/rust/worker/src/segment/record_segment.rs @@ -814,22 +814,22 @@ impl RecordSegmentReader<'_> { self.id_to_data.count().await } - pub(crate) async fn prefetch_id_to_data(&self, keys: &Vec) -> () { + pub(crate) async fn prefetch_id_to_data(&self, keys: Vec) -> () { let prefixes = vec![""; keys.len()]; - self.id_to_data.load_blocks_for_keys(&prefixes, keys).await + self.id_to_data.load_blocks_for_keys(prefixes, keys).await } - pub(crate) async fn prefetch_user_id_to_id(&self, keys: &Vec<&str>) -> () { + pub(crate) async fn prefetch_user_id_to_id(&self, keys: Vec<&str>) -> () { let prefixes = vec![""; keys.len()]; self.user_id_to_id - .load_blocks_for_keys(&prefixes, keys) + .load_blocks_for_keys(prefixes, keys) .await } - pub(crate) async fn prefetch_id_to_user_id(&self, keys: &Vec) -> () { + pub(crate) async fn prefetch_id_to_user_id(&self, keys: Vec) -> () { let prefixes = vec![""; keys.len()]; self.id_to_user_id - .load_blocks_for_keys(&prefixes, keys) + .load_blocks_for_keys(prefixes, keys) .await } }