eviscerate runLighthouse

[paulirish]

@brendankenny this yeah?

it's accompanied with these devtools changes:

diff --git a/front_end/audits_worker/AuditsService.js b/front_end/audits_worker/AuditsService.js
index a66191cb..f8d6bc80 100644
--- a/front_end/audits_worker/AuditsService.js
+++ b/front_end/audits_worker/AuditsService.js
@@ -51,8 +51,19 @@ var AuditsService = class {  // eslint-disable-line
       this.statusUpdate(message[1]);
     });
 
+
     return Promise.resolve()
-        .then(_ => self.runLighthouseInWorker(this, params.url, params.flags, params.categoryIDs))
+        .then(_ => {
+          const flags = params.flags;
+          flags.logLevel=flags.logLevel||'info';
+          flags.channel='devtools';
+
+          const connection = self.setUpWorkerConnection(this);
+          const config = getDefaultConfigForCategories(params.categoryIDs);
+          const url = params.url;
+
+          return self.runLighthouse(url, flags, config, connection)
+        })
         .then(/** @type {!ReportRenderer.RunnerResult} */ result => {
           // Keep all artifacts on the result, no trimming
           return result;
@@ -126,6 +137,8 @@ var AuditsService = class {  // eslint-disable-line
 
 // Make lighthouse and traceviewer happy.
 global = self;
+global.devtools=true;
+
 global.isVinn = true;
 global.document = {};
 global.document.documentElement = {};

[brendankenny]

Yep, LGTM!

+global.devtools=true

except where did that sneak in from :)

[paulirish]

+global.devtools=true

except where did that sneak in from :)

from the dt-5-7 branch.

ill cherrypick @chruxin's PR into that branch and roll that to devtools.

[paulirish]

@chruxin can you merge this? it'll bring my commit into your existing PR.