-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure worker_save_query_explain_analyze always fully qualifies types #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5776 +/- ##
==========================================
- Coverage 92.64% 92.61% -0.03%
==========================================
Files 228 227 -1
Lines 47474 47379 -95
==========================================
- Hits 43980 43880 -100
- Misses 3494 3499 +5 |
A nice test case suggestion: create schema my_schema;
create type my_schema.my_type as (int_field int);
create table tbl (a my_schema.my_type);
SELECT create_distributed_table('tbl', 'a');
set search_path to my_schema,public;
explain analyze select * from tbl ; --worker query crashes
WARNING: SSL SYSCALL error: EOF detected
connection not open
WARNING: terminating connection because of crash of another server process
DETAIL: The postmaster has commanded this server process to roll back the current transaction and exit, because another server process exited abnormally and possibly corrupted shared memory.
HINT: In a moment you should be able to reconnect to the database and repeat your command.
ERROR: type "my_type" does not exist
CONTEXT: while executing command on localhost:10700
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Failed. |
onurctirtir
reviewed
Mar 9, 2022
onurctirtir
force-pushed
the
marcocitus/fix-explain
branch
from
March 9, 2022 16:18
31cdd15
to
ec839f4
Compare
onurctirtir
reviewed
Mar 9, 2022
🚢 looks good to me |
onurctirtir
approved these changes
Mar 10, 2022
marcocitus
added a commit
that referenced
this pull request
Mar 11, 2022
…#5776) Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com> Co-authored-by: Marco Slot <marco.slot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Fixes a bug that could cause worker_save_query_explain_analyze to fail on custom types
We've seen cases where EXPLAIN ANALYZE fails when the query returns a type that is on the search_path on the coordinator, but not on the worker, because format_type does not qualify the name in that case.