Install dev requirements in stylechecker #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
force-pushed
the
dev-requirements-in-stylechecker
branch
3 times, most recently
from
4a58d9a to
46b024e
Compare
hanefi
approved these changes
Feb 8, 2023
Comment on lines
5
to
25
| RUN apk add --no-cache --virtual installdeps \ | ||
| curl \ | ||
| make \ | ||
| cmake \ | ||
| gcc \ | ||
| g++ \ | ||
| musl-dev \ | ||
| python3-dev \ | ||
| && apk add --no-cache \ | ||
| ca-certificates \ | ||
| cmake \ | ||
| bash \ | ||
| git \ | ||
| grep \ | ||
| gzip \ | ||
| musl-dev \ | ||
| openssh \ | ||
| perl \ | ||
| python3 \ | ||
| py3-pip \ | ||
| tar \ |
There was a problem hiding this comment.
I really like the effort to delete all install dependencies and leave only the packages that will be used in the package. However, I do not really get how and why some of the packages that are not listed under the virtual installdeps are used in the actual image. For example can we move the following to installdeps virtual package:
cmakeappears to be used only when building uncrustifygzipis used when extracting uncrustify tarballmusl-devis a standard C library. I do not really know why we need it at allopensshdoes not look like used at all as we use https connections for github and I do not see any other place that can actually use ssh.py3-pipis used only here to install packages. Is it not safe to delete it after we are done with installing python packages? Deleting this package may also delete the python packages, so I am not sure if it is safe to move it to virtual package list at all.taris used when extracting uncrustify tarball.
There was a problem hiding this comment.
Moved all of these packages to installdeps. Two callouts:
- I added py3-packaging to regular installed packages. Since py3-pip pulled that in and it's needed to run our linters due to pyproject.toml.
- musl-dev is needed during build because some python packages need it to compile some C stuff.
There was a problem hiding this comment.
Okay added back openssh. It's necessary for circleci to check out the github repo.
JelteF
force-pushed
the
dev-requirements-in-stylechecker
branch
2 times, most recently
from
a8b1f56 to
1fd7bde
Compare
Needed to check Python formatting and linting from CI for citusdata/citus#6700
JelteF
force-pushed
the
dev-requirements-in-stylechecker
branch
from
1fd7bde to
6139186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to check Python formatting and linting from CI for citusdata/citus#6700
Since some of these tools need a somewhat recent python version this also required an update of the alpine base image. And to make that in turn work, we need to install
uncrustifyfrom source (just like we recommend devs to do).