[BUG] Update AttachVolume method to use VolumeAttachConfig due to civogo v0.3.75 upgrade

[Praveen005]

Description

What's the Issue?

When we update the Provider's civogo dependency to v0.3.75, which the latest one,

the AttachVolume method expects us to provide VolumeAttachConfig instead of instanceID.

terraform-provider-civo/civo/volume/resource_volume_attachment.go

Line 69 in 2adc815

_, err := apiClient.AttachVolume(volumeID, instanceID)

Type VolumeAttachConfig was added recently, as evident in the screenshot below:

Steps to reproduce:

Just update the dependency using go get github.com/civo/civogo command.

Acceptance Criteria

• Should be able to create the resource_volume_attachment with the updated dependency

[Praveen005]

Hi @uzaxirr

I worked on this and would like explain my approach for your review.

I stumbled upon this while working on #332. Comment Here highlights that.

Earlier AttachVolume method expected an instance ID to be passed along with volume ID, but now requires
VolumeAttachConfig to be passed in place of instanceID.

https://github.com/civo/civogo/blob/4fee779533b0cfd41ff2f53b4ea57b052848ac05/volume.go#L44-L49

Fix:

volumeConfig.Region = apiClient.Region sets the Region to the value specified in provider config.

up next,

if region, ok := d.GetOk("region"); ok {
	apiClient.Region = region.(string)
	volumeConfig.Region = region.(string)
}

overwrites the Region, if it is specified in the resource config.

Specifying Region is necessary because, volume attachment will fail if there is a region mismatch.

More context:

I faced a peculiar issue, my default region was NYC1 but provider had LON1 and I didn't set Region field of the volumeConfig, it took the default NYC1 while other resources had LON1 and I was presented with a completely unrelated error.

Setting volumeConfig.Region fixed this.

Other changes are trivial, like setting the volumeConfig.InstanceID and then passing volumeConfig to the AttachVolume method.

---

Result:

Successful resource_volume_attachment creation:

------------------------------------------------------------------------------

Questions:

Should the sample code in the doc here be updated to include civo_firewall resource, since it is a required field for civo_instance resource?

I have also changed civo_instances_size to civo_size in the doc.

Thank You!

[uzaxirr]

Feel free to raise a PR

[Praveen005]

Hi @uzaxirr,

#341 would fix this issue.