Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional catch all routes [[...category]] route ? #12

Closed
revskill10 opened this issue Apr 12, 2021 · 5 comments · Fixed by #13
Closed

Optional catch all routes [[...category]] route ? #12

revskill10 opened this issue Apr 12, 2021 · 5 comments · Fixed by #13
Assignees

Comments

@revskill10
Copy link

Hi, thanks for great library.

I have one issue about wildcard route, like /store/[store]/[[...category]] , i see it generates as route /store/[store]/[[ only.

Could you please check this use case ?

@revskill10 revskill10 changed the title Wildcard [[...category]] route ? Optional catch all routes [[...category]] route ? Apr 12, 2021
@ckastbjerg
Copy link
Owner

Hi Truong!

Glad you like it :) And thanks for submitting this issue.

I didn't think about that use case, no. I will have a look at supporting it very soon.

/Christian

@ckastbjerg ckastbjerg self-assigned this Apr 13, 2021
@ckastbjerg ckastbjerg linked a pull request Apr 13, 2021 that will close this issue
@ckastbjerg
Copy link
Owner

@revskill10 after a bit of thinking, I feel like I found a decent solution for this use case :)
If you have time, could you please let me know if this interface makes sense to you: #13?

@ckastbjerg
Copy link
Owner

I've released the changes as I didn't want to keep the PR open too long. If this doesn't solve your issue, let me know. And I'll have another look at it :)

@revskill10
Copy link
Author

@ckastbjerg Huge thanks. I'll try out and post issues if i've got any !

@revskill10
Copy link
Author

For further investigation, if you have a look at i18n routing, it would be awesome 👯‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants