Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in About Dialog points to CKEditor 3.x user's guide. #532

Closed
jswiderski opened this issue Jun 20, 2017 · 9 comments
Closed

Link in About Dialog points to CKEditor 3.x user's guide. #532

jswiderski opened this issue Jun 20, 2017 · 9 comments
Assignees
Labels
status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

jswiderski commented Jun 20, 2017

Are you reporting a feature or a bug?

BUG

Provide detailed reproduction steps (if any)

  1. Open about dialog and click on the "Check CKEditor User's Guide for help."

Expected result

User's guide link should point to http://docs.ckeditor.com/#!/guide/dev_features. Also the text should probably be changed.

Edit by mlewand: There's no need to keep this link any longer. Let's just remove it.

Actual result

The link in about dialog- "Check CKEditor User's Guide for help." is pointing to http://docs.cksource.com/CKEditor_3.x/Users_Guide

Other details

  • Browser: any
  • OS: any
  • CKEditor version: 4.0+
  • Installed CKEditor plugins: N/A
@jswiderski jswiderski added type:bug A bug. status:confirmed An issue confirmed by the development team. labels Jun 20, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 6, 2017
@mlewand mlewand added this to the Backlog milestone Nov 6, 2017
@AnnaTomanek AnnaTomanek self-assigned this Nov 6, 2017
@mlewand mlewand modified the milestones: Backlog, 4.8.0 Nov 6, 2017
@wojtekidd
Copy link

wojtekidd commented Nov 14, 2017

We're getting rid of this line (approved by @wwalc ) however all users who have an older version of CKEditor should be actually redirected somewhere and I think the link suggested by @jswiderski makes sense.

@wwalc
Copy link
Member

wwalc commented Nov 14, 2017

Just remove that line. Regarding users with older releases, keep it as is, no redirects or anything like that.

Reasoning: the old link still shows a better users guide for the end users than features overview, which has a different target audience.

@wojtekidd
Copy link

The old link shows me this:
screen shot 2017-11-15 at 09 25 04

@msamsel
Copy link
Contributor

msamsel commented Nov 15, 2017

@wojtekidd it was corrected within #1041, so it will work correctly with 4.8.0 release.
Take a look at nightly build :) http://nightly.ckeditor.com/17-11-15-07-05/full/samples/

@wwalc
Copy link
Member

wwalc commented Nov 15, 2017

@wojtekidd about which link you were talking about?

screen shot 2017-11-15 at 12 45 38

@wwalc
Copy link
Member

wwalc commented Nov 15, 2017

C'mon https://docs.ckeditor.com/ckeditor4/docs/ is not user's guide.

@wwalc
Copy link
Member

wwalc commented Nov 15, 2017

@msamsel I just talked with @wojtekidd and hereby confirm that this paragraph with a link to User's Guide should be still removed.

@msamsel
Copy link
Contributor

msamsel commented Nov 15, 2017

In #1041 I just correct most of the links to use https and do not additionally redirect user. Also change this link to point to CKEditor4 documentation not CKEditor3 as it seems to be wrong.

About About plugin I talk with @AnnaTomanek, when I clean up all those URLs, and as far as I remember corrects to this plugin (links, logos, etc stuff) remain to be done with this issue.

@mlewand
Copy link
Contributor

mlewand commented Nov 22, 2017

So we decided we're not going to keep this link in the dialog and we'll just remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

6 participants