Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken content in article editor after using shortcut CTRL+Z #704

Closed
beatadelura opened this issue Jul 31, 2017 · 2 comments · Fixed by #734
Closed

Broken content in article editor after using shortcut CTRL+Z #704

beatadelura opened this issue Jul 31, 2017 · 2 comments · Fixed by #734
Assignees
@msamsel
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@beatadelura
Copy link
Contributor

beatadelura commented Jul 31, 2017 •
edited
Loading

Are you reporting a feature or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open Edge browser.
  2. Go to http://ckeditor.com/ and choose Article Editor.
  3. Put caret at the end of the text.
  4. Press Enter.
  5. Use CTRL+Z shortcut to undo.

Expected result

The layout looks the same as before use CTRL+Z shortcut.

Actual result

The layout is broken.

Other details

  • Support ticket number: 32334
  • Browser: Microsoft Edge 38.14393.1066.0, Microsoft EdgeHTML 14.14393
  • OS: Windows 10

If you use the F12 developer tools to change the User Agent String to Chrome the site works as expected.

Here is additional information about the Edge UA String: https://msdn.microsoft.com/library/hh869301(v=vs.85).aspx
@beatadelura beatadelura added browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jul 31, 2017
@jswiderski jswiderski added the support An issue reported by a commercially licensed client. label Jul 31, 2017
@mlewand
Copy link
Contributor

mlewand commented Aug 1, 2017 •
edited
Loading

Interestingly it does destroy the widget structure when pressing ctrl+z, and does not happen if you undo using toolbar button, so it's not the issue with the undo command itself.

Also I can not reproduce this issue on old widget demos like: http://cdn.ckeditor.com/4.7.1/full-all/samples/old/image2/image2.html

Widgets are also broken in "Features" / "Developer Site Editor" editor. Interestingly inline editors seems not to be affected by this issue, see "features" / "Drag & Drop".

@mlewand mlewand added this to the Backlog milestone Aug 1, 2017
@msamsel msamsel self-assigned this Aug 1, 2017
@msamsel msamsel mentioned this issue Aug 7, 2017
Merged
2 tasks
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Aug 30, 2017
@f1ames f1ames added target:major Any docs related issue that should be merged into a major branch. and removed target:minor Any docs related issue that can be merged into a master or major branch. labels Sep 12, 2017
@f1ames f1ames modified the milestones: 4.8.0, Backlog Sep 13, 2017
f1ames added a commit that referenced this issue Sep 13, 2017
@f1ames
Merge pull request #734 from ckeditor/t/704
37f6a4b 
[#704] Fix broken widget after using Ctrl+Z in Edge.
@f1ames
Copy link
Contributor

f1ames commented Sep 13, 2017

Closed in #734.

@f1ames f1ames closed this as completed Sep 13, 2017
f1ames added a commit that referenced this issue Sep 13, 2017
@f1ames
Changelog entry for #704. [skip ci]
5206d91
Comandeer added a commit that referenced this issue Sep 13, 2017
@Comandeer
Merge pull request #907 from ckeditor/t/704_changelog
8d5490d 
Changelog entry for #704. [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

[#704] Fix broken widget after using Ctrl+Z in Edge ckeditor/ckeditor4
5 participants
@f1ames @jswiderski @mlewand @msamsel @beatadelura