Double-click on link opens empty link dialog due to bug in getSelectedLink

[MichaelRoosz]

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

1. Open CKEditor sample, eg. from cdn.
2. Switch editor to source mode.
3. Insert into editor:

   <p><a class="linkClass" href="https://www.google.pl"><img src="http://lorempixel.com/10/20/" /> some button text </a></p>

4. Switch back to WYSIWYG mode.
5. Double-click on some button text

Expected result

The link dialog should show with proper link data. Check especially:

• "URL" field in "Link Info" tab (it should contains "https://www.google.pl"),
• "Stylesheet Classes" field in "Advanced" tab (it should contains "linkClass").

Actual result

The link dialog does not have data described above.

Other details

What I found out so far:

• getSelectedLink (editor, false) works
• on right-click selection.getSelectedElement() is null, but when I double-click it points to the correct a
• on right-click range.getCommonAncestor() points to the some button text, on double-click range.getCommonAncestor() points to the p tag <<<< this causes the problem in my opinion.

• Browser: Chrome
• OS: Windows
• CKEditor version: 4.7.2

[MichaelRoosz]

This fix works for me.

[wojtekw92]

regression since 4.7.0

[mlewand]

I have created a quick unit test for that: https://gist.github.com/mlewand/4b61bbd8540de0b1ecc00e0c99e12404

[lslowikowska]

Hey @MichaelHeerklotz just to let you know, the fix has been merged into the master branch - we have just decided to skip the minor release (4.8.1) and go straight to 4.9.0, which means that this fix will be released with 4.9.0, too (check the milestones page).

If you can't wait for it, you can download the nightly release from the "CKEditor Nightly Build" section on our download page. Keep in mind, however, that it has not been verified by our integration testing phase yet as we will do this right before the release.

[Comandeer]

I've updated issue's title and description.