Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear error message for width and height fields #889

Closed
b2m opened this issue Sep 11, 2017 · 3 comments
Closed

Unclear error message for width and height fields #889

b2m opened this issue Sep 11, 2017 · 3 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image The plugin which probably causes the issue. plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@b2m
Copy link

b2m commented Sep 11, 2017

Are you reporting a feature request or a bug?

This is a duplicate of the Bugreport by Anjaneyulu on https://dev.ckeditor.com/ticket/14280. It regards the error message shown for invalid values in the width and height fields that are available in the dialogs for images and possibly more.

Check if the issue is already reported

Provide detailed reproduction steps (if any)

  1. Go to https://sdk.ckeditor.com/samples/standardpreset.html
  2. Open Image Dialog
  3. Enter a number into the width or height field like: 0, -200, or 3.1415926
  4. Click Ok.

Expected result

An error message should be shown describing valid values for the width and height fields.
Something like Width must be a natural number > 0

Actual result

The shown error message says Width must be a number.

Other details

  • CKEditor version: 4.7.2
@wojtekw92 wojtekw92 self-assigned this Sep 11, 2017
@wojtekw92
Copy link
Contributor

Hi @b2m,
thank you for creating issue. Are you sure that you can reproduce this issue on 4.7.2?
When I try to reproduce this issue on http://cdn.ckeditor.com/4.7.2/full-all/samples/
I'm getting proper error message:
screen shot 2017-09-11 at 10 36 33

@b2m
Copy link
Author

b2m commented Sep 11, 2017

Hi @wojtekw92
Reproduced with the images2 dialog on 4.7.2.
Not with the tables dialog => modified my error description accordingly.

Language Keys: invalidHeight and invalidWidth.

@wojtekw92 wojtekw92 added status:confirmed An issue confirmed by the development team. type:bug A bug. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. and removed status:pending labels Sep 12, 2017
@wojtekw92 wojtekw92 removed their assignment Sep 13, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Dec 14, 2017
@f1ames f1ames added plugin:image The plugin which probably causes the issue. plugin:image2 The plugin which probably causes the issue. labels Dec 14, 2017
@f1ames f1ames added this to the 4.8.1 milestone Dec 14, 2017
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
@lslowikowska
Copy link

lslowikowska commented Jan 19, 2018

Hey @b2m just to let you know, the fix has been merged into the master branch - we have just decided to skip the minor release (4.8.1) and go straight to 4.9.0, which means that this fix will be released with 4.9.0, too (check the milestones page).

If you can't wait for it, you can download the nightly release from the "CKEditor Nightly Build" section on our download page. Keep in mind, however, that it has not been verified by our integration testing phase yet as we will do this right before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image The plugin which probably causes the issue. plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants