Skip to content

Commit

Permalink
Review fixes:
Browse files Browse the repository at this point in the history
- ignore manual tests on non-edge browser and omit usage of addEventListener
- typo fixes
- syntax fixes
  • Loading branch information
Mateusz Samsel committed Sep 13, 2017
1 parent 3162c03 commit 55d68ec
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@
</textarea>
<pre id="output" style="background-color: lightgreen;"></pre>
<script>
if ( !CKEDITOR.env.edge ) {
bender.ignore();
}

var editor = CKEDITOR.replace( 'editor1', {
height: '600px'
} );
var output = document.getElementById( 'output' )
var output = document.getElementById( 'output' );
editor.on( 'instanceReady', function() {
editor.editable().$.addEventListener( 'keyup', function() {
editor.editable().$.onkeyup = function() {
output.innerText = editor.editable().getFirst().getName();
} );
});
};
} );
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
1. Put caret in the text on the right and type some text.
1. Use `Ctrl + Z` or `Cmd + Z` shortcut to make undo few times.

**Expected:** Text returns to previous form. Below editor will be written `div` on green background.
**Expected:** Text returns to previous form. Below the editor, you should see `div` on green background.

**Unexpected:** Text moves below the image. Below editor will be written `figure` instead of `div`.
**Unexpected:** Text moves below the image. Below editor, it will be written `figure` instead of `div` on the green background.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

bender.test( {
// #704
'test keeping widget wrapper in editor when superflous elemnts are checked': function() {
'test keeping widget wrapper in editor when superfluous elements are checked': function() {
CKEDITOR.plugins.add( 'test', {
requires: 'widget',
init: function( editor ) {
Expand Down

0 comments on commit 55d68ec

Please sign in to comment.