Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles form stylesSet for LI applicable only if element selected via elements path #1395

Closed
f1ames opened this issue Jan 3, 2018 · 1 comment
Labels
plugin:stylescombo The plugin which probably causes the issue. resolution:cantreproduce A report that is not reproducible. type:bug A bug.

Comments

@f1ames
Copy link
Contributor

f1ames commented Jan 3, 2018

Are you reporting a feature request or a bug?

Bug

Check if the issue is already reported

Related to stylesSet, but covering slightly different case: https://dev.ckeditor.com/ticket/9405

Provide detailed reproduction steps (if any)

  1. Create editor with config like:
{
  stylesSet: [
    { name: 'LI No Margin', element: 'li', attributes: { 'style': 'margin: 0;' } },
    { name: 'LI Small Margin', element: 'li', attributes: { 'style': 'margin: 5px 0;' } },
    { name: 'LI Medium Margin', element: 'li', attributes: { 'style': 'margin: 10px 0;' } }
  ]
}
  1. Insert list and try to apply styles defined in stylesSet to list item.

Expected result

It is possible to apply styles when whole list item is selected (I suppose it should not be applicable for partial or collapsed selection).

Actual result

Styles are only applicable when li element has been selected vie elements path.


Could be reproduced also on https://codepen.io/f1ames/pen/ypoeLb?editors=1010.

jan-03-2018 10-59-12

Other details

  • Browser: Tested on Chrome and FF
  • OS: All
  • CKEditor version: 4.7.3
  • Installed CKEditor plugins: full preset
@f1ames f1ames added plugin:stylescombo The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jan 3, 2018
@f1ames
Copy link
Contributor Author

f1ames commented Jan 3, 2018

Keeping for future reference as it was fixed in 4.8.0 with #862.

@f1ames f1ames closed this as completed Jan 3, 2018
@mlewand mlewand added resolution:cantreproduce A report that is not reproducible. and removed status:confirmed An issue confirmed by the development team. labels Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:stylescombo The plugin which probably causes the issue. resolution:cantreproduce A report that is not reproducible. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

2 participants