-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File browser plugin is no longer compatible with CKFinder 2.4.2 and older #1869
Comments
What @jonnott has reported seems to be valid for CKFinder 2.4.2 and below but works fine for CKFinder 2.5 and above including latest CKFinder 2.6.2. In CKFinder 2.5 the response is JSON however in CKFinder 2.4.2 and below the response is text. Please see attached images. It needs further investigation however it may turn out that JSON requirement will make CKFinder 2.4.2- incompatible with latest CKEditor 4.9.1 |
Thanks for the research @jswiderski! Back to the matter: you should upgrade to the latest CKFinder version. Alternatively if for some reason you really can't upgrade, you can fallback to changing: |
@mlewand Problem is, with v2.4.2 of CKFinder, the way the license check was done (or the nature of the license itself, I can't remember) changed .. so in order to keep using v2.x, purchasing a new license was needed. This really shouldn't have been the case until v3.x, as it means those with an older license couldn't use > 2.4.0 .. which isn't great. |
@jonnott the configuration option @mlewand has mentioned is for CKEditor and not for CKFinder so using it as shown below:
should make images work and should not influence license check in any way. Could you please check if the above is working for you? |
Yep, all good now. There should probably be some notes in either one-or-other app's documentation that |
As mentioned, the workaround has been provided. But remember that CKF 2.4.2 is already 4 years old. |
Yes, thanks for the workaround. But the fact there's a workaround possible doesn't mean that the compatibility break should not be documented, so that others don't find the same problem.. |
@mlewand This documentation for CKFinder 2 integration needs updating to specify https://docs.ckeditor.com/ckeditor4/latest/guide/dev_ckfinder_integration.html#ckfinder-2 |
Are you reporting a feature request or a bug?
Bug
Issue 1835 doesn't resolve the issue for CKFinder v2.x, only v3.x .. see comments here:
#1835 (comment)
The text was updated successfully, but these errors were encountered: