Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser plugin is no longer compatible with CKFinder 2.4.2 and older #1869

Closed
jonnott opened this issue Apr 7, 2018 · 8 comments
Closed
Labels
resolution:invalid Not a valid issue (wrong request type, support requests, etc).

Comments

@jonnott
Copy link

jonnott commented Apr 7, 2018

Are you reporting a feature request or a bug?

Bug

Issue 1835 doesn't resolve the issue for CKFinder v2.x, only v3.x .. see comments here:

#1835 (comment)

@jswiderski
Copy link
Contributor

What @jonnott has reported seems to be valid for CKFinder 2.4.2 and below but works fine for CKFinder 2.5 and above including latest CKFinder 2.6.2.

In CKFinder 2.5 the response is JSON however in CKFinder 2.4.2 and below the response is text. Please see attached images. It needs further investigation however it may turn out that JSON requirement will make CKFinder 2.4.2- incompatible with latest CKEditor 4.9.1

ckf242 headers
ckf242 response

ckf25 headers
ckf25 response

@mlewand
Copy link
Contributor

mlewand commented Apr 9, 2018

Thanks for the research @jswiderski! Back to the matter: you should upgrade to the latest CKFinder version.

Alternatively if for some reason you really can't upgrade, you can fallback to changing: config.filebrowserUploadMethod to form value. However you should always work with the latest version of the software.

@mlewand mlewand closed this as completed Apr 9, 2018
@mlewand mlewand added the resolution:invalid Not a valid issue (wrong request type, support requests, etc). label Apr 9, 2018
@mlewand mlewand changed the title Issue 1835 doesn't solve issue for CKFinder v2.x File browser plugin is no longer compatible with CKFinder 2.4.2 and older Apr 9, 2018
@jonnott
Copy link
Author

jonnott commented Apr 9, 2018

@mlewand Problem is, with v2.4.2 of CKFinder, the way the license check was done (or the nature of the license itself, I can't remember) changed .. so in order to keep using v2.x, purchasing a new license was needed. This really shouldn't have been the case until v3.x, as it means those with an older license couldn't use > 2.4.0 .. which isn't great.

@jswiderski
Copy link
Contributor

jswiderski commented Apr 9, 2018

@jonnott the configuration option @mlewand has mentioned is for CKEditor and not for CKFinder so using it as shown below:

var editor = CKEDITOR.replace( 'editor1', {
	filebrowserUploadMethod : 'form'	
} ); 
CKFinder.setupCKEditor( editor, '../' ) ;

should make images work and should not influence license check in any way.

Could you please check if the above is working for you?

@jonnott
Copy link
Author

jonnott commented Apr 9, 2018

Yep, all good now. There should probably be some notes in either one-or-other app's documentation that filebrowserUploadMethod : 'form' is needed for versions of CKFinder prior to 2.5 to work with CKEditor 4.9+..

@mlewand
Copy link
Contributor

mlewand commented Apr 9, 2018

As mentioned, the workaround has been provided. But remember that CKF 2.4.2 is already 4 years old.

@jonnott
Copy link
Author

jonnott commented Apr 9, 2018

Yes, thanks for the workaround. But the fact there's a workaround possible doesn't mean that the compatibility break should not be documented, so that others don't find the same problem..

@jonnott
Copy link
Author

jonnott commented Apr 11, 2018

@mlewand This documentation for CKFinder 2 integration needs updating to specify filebrowserUploadMethod : 'form' is required..

https://docs.ckeditor.com/ckeditor4/latest/guide/dev_ckfinder_integration.html#ckfinder-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:invalid Not a valid issue (wrong request type, support requests, etc).
Projects
None yet
Development

No branches or pull requests

3 participants