Font family and size default list item shoudl leverage the config labels

[blindspeed90]

Type of report

Bug

Provide detailed reproduction steps (if any)

Version 4.8 for #584 added a stock "(Default)" label list item, which does not leverage the default labels provided in the config.

Expected result

I'd expect the config default label to be used.

Actual result

It is not used.

Other details

In the font plugin, instead of:

defaultText = '(' + editor.lang.common.optionDefault + ')';

this:
defaultText = (defaultLabel || '(' + editor.lang.common.optionDefault + ')');

would be more appropriate.

[jacekbogdanski]

To make it more clear, config.font_defaultLabel is respected when the editor is focused. However, it's not set on editor initialization.

For me, it also makes sense that the label should be set as default from the beginning of the editor initialization.

@blindspeed90 please also correct me if I misunderstood the issue.

[blindspeed90]

What you're describing is a separate bug that I kind of forgot about. It says "Font" and "Size" and then click in the editor or toolbar and those two values change. So yes I agree that those should have been set to the label then also.

[f1ames]

@blindspeed90 To be on the same page, the issue you reported is that the font_defaultLabel config is not used and instead combo shows (Default) value?

[blindspeed90]

Yes