Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing items in a11yhelp dialog #512

Closed
msamsel opened this issue Jun 14, 2017 · 3 comments
Closed

Missing items in a11yhelp dialog #512

msamsel opened this issue Jun 14, 2017 · 3 comments
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@msamsel
Copy link
Contributor

msamsel commented Jun 14, 2017 •
edited
Loading

Are you reporting a feature or a bug?

BUG

Provide detailed reproduction steps (if any)

Problem exist on master branch. It's not present on 4.7.0

  1. focus editor
  2. press ALT+0 to open a11yhelp
  3. in General section there are only 2 entries: Editor DialogEditor Dialog and Editor List Box instead of entire help list.

Expected result

Full list visible.

Actual result

Not-full list present in dialog.

Other details

  • CKEditor version: master branch

Blocked by #523
@mlewand mlewand added status:confirmed An issue confirmed by the development team. regression This issue is a regression. type:bug A bug. labels Jun 14, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 14, 2017

It was probably introduced with #413 as it's not reproducible on 4.7.0 but it is on the latest master branch.

@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Jun 14, 2017
@mlewand
Copy link
Contributor

mlewand commented Jun 26, 2017

I believe this ticket was fixed recently @msamsel could you confirm it?

@msamsel
Copy link
Contributor Author

msamsel commented Jun 26, 2017

Problem is not exist any longer. It was introduced in commit 33ddded. After fixing method getCommandKeystroke everything is working ok.

@msamsel msamsel closed this as completed Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlewand @msamsel