Update main sample page with new CKEditor logo #1409

msamsel · 2018-01-05T13:00:28Z

What is the purpose of this pull request?

task

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

Unit tests
Manual tests

What changes did you make?

replace logo in sample to be new one
update css colours in sample.

close #1337

mlewand

Love the new color, however the changes should be applied in less file, and then it should be used to rebuild .css file.

msamsel · 2018-01-18T13:46:50Z

I had to correct path to lesshat, because grunt less was not working. After path update in less config, css might be easily update from less files with grunt less command.

mlewand

Frw minor things, and as for the image, couldn't we go with an svg with a fallback to png for old IEs? That would make the logo look nice on screens with higher pixel density than 200%.

mlewand · 2018-01-25T15:12:53Z

samples/css/samples.css

@@ -1,5 +1,5 @@
 /**
- * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.


Please revert this change, it's not a subject of this issue. It's done in other PR, and your change here will cause merging conflicts.

Remove it by editing your commit history, as if the change never happened.

mlewand · 2018-01-25T15:13:32Z

samples/css/samples.css

+  height: 60px;
+}
+/**
+ * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.


Why did these headers leaked here? 😕

I haven't touch manually .css file, so all changes was made by grunt less script.

mlewand · 2018-01-25T15:19:59Z

samples/less/samples.less

@@ -2,7 +2,7 @@
 @components-dir: "../../node_modules/cksource-samples-framework/components";

 // Good 'ol Lesshat.
-@import "../../node_modules/cksource-samples-framework/node_modules/lesshat/build/lesshat";
+@import "../../node_modules/lesshat/build/lesshat";


If we were to use it that way we need to add lesshat as a dev dependency to our project too.

I'm pretty sure that I get error multiple times because this file wasn't present. It seems that I had some repository problem after reinstallation it's there.

It depends on npm resolution. Currently node will put deps of your deps in your node_modules directory, but will that be the case in a year from here? We don't know.

Thus it needs to be added to deps.

I wrongly interpret the previous comment then ;)

msamsel · 2018-01-30T10:44:52Z

SVG added with fallback for not supported browsers. Replace image to be exact size, as now we have svg for hidpi. Update styles to scale svg to proper size.

mlewand · 2018-01-31T15:02:50Z

CHANGES.md

 API Changes:

 * [#1346](https://github.com/ckeditor/ckeditor-dev/issues/1346): [Balloon Toolbar](https://ckeditor.com/cke4/addon/balloontoolbar) [context manager API](https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.plugins.balloontoolbar.contextManager) is now available in [pluginDefinition.init](https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.pluginDefinition-method-init) method of a [requiring](https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.pluginDefinition-property-requires) plugin.

+Other Changes:
+
+* [#1337](https://github.com/ckeditor/ckeditor-dev/issues/1337): Update `samples` layout with actuall CKEditor logo and coherent color scheme.


actuall -> actual

mlewand

#1409 (comment) was not adressed.

msamsel · 2018-01-31T15:26:17Z

add devDepndancy
correct path to lesshat in our less file
regenerate styles.css to have sure that script works properly
package.json was also sorted when npm i -D ... was used
fix changelog typo

mlewand

Pushed minor correction to change log entry.

Agh, I just found another small issue, toolbar configurator contains png-only logo, could you fix that?

msamsel · 2018-02-05T11:18:19Z

I completely forget about toolbar configuration :(

…re coherent with new logo.

…esshat.

mlewand

LGTM

mlewand added the review:easy Pull requests that can be reviewed by a Junior Developer before being reviewed by the Reviewer. label Jan 8, 2018

mlewand self-requested a review January 15, 2018 16:09

mlewand mentioned this pull request Jan 15, 2018

SDK should use new CKE4 logo and branding colors ckeditor/ckeditor4-sdk#234

Closed

mlewand suggested changes Jan 15, 2018

View reviewed changes

msamsel force-pushed the t/1337 branch from 2dac304 to f9f9d3a Compare January 18, 2018 13:41

msamsel changed the base branch from master to major January 18, 2018 13:41

msamsel requested a review from mlewand January 18, 2018 13:49

mlewand suggested changes Jan 25, 2018

View reviewed changes

msamsel force-pushed the t/1337 branch from f9f9d3a to fd43944 Compare January 30, 2018 10:36

msamsel force-pushed the t/1337 branch from fd43944 to 51d9846 Compare January 30, 2018 10:46

mlewand self-requested a review January 31, 2018 15:01

mlewand reviewed Jan 31, 2018

View reviewed changes

mlewand suggested changes Jan 31, 2018

View reviewed changes

msamsel force-pushed the t/1337 branch from 51d9846 to dea950a Compare January 31, 2018 15:23

msamsel force-pushed the t/1337 branch from dea950a to 479d01a Compare January 31, 2018 15:28

msamsel requested a review from mlewand January 31, 2018 15:31

mlewand suggested changes Feb 5, 2018

View reviewed changes

msamsel force-pushed the t/1337 branch from 0c37385 to 2eac44c Compare February 5, 2018 11:17

Mateusz Samsel and others added 8 commits February 5, 2018 12:19

Update main sample page with new CKEditor logo. Adapt colors to be mo…

c443b3a

…re coherent with new logo.

Update less file to use new color and logo's style. Correct path to l…

b76f81f

…esshat.

Update css acording to new less rules.

8af45bf

Add changelog entry.

7e19246

Add svg logo and fallback to png for older browsers in sample html.

215889d

Add dev dependancy from lesshat for our samples.

dfb3407

Adjusted changelog entry.

7b03a0d

Update samples/toolbarconfiguration with svg logo.

fef0c20

msamsel force-pushed the t/1337 branch from 2eac44c to fef0c20 Compare February 5, 2018 11:20

msamsel requested a review from mlewand February 5, 2018 11:20

mlewand approved these changes Feb 5, 2018

View reviewed changes

mlewand merged commit 5a7a0f4 into major Feb 5, 2018

mlewand deleted the t/1337 branch February 5, 2018 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update main sample page with new CKEditor logo #1409

Update main sample page with new CKEditor logo #1409

msamsel commented Jan 5, 2018

mlewand left a comment

msamsel commented Jan 18, 2018

mlewand left a comment

mlewand Jan 25, 2018

mlewand Jan 25, 2018

msamsel Jan 30, 2018

mlewand Jan 25, 2018

msamsel Jan 30, 2018

mlewand Jan 31, 2018

msamsel Jan 31, 2018

msamsel commented Jan 30, 2018 •

edited

Loading

mlewand Jan 31, 2018

mlewand left a comment

msamsel commented Jan 31, 2018 •

edited

Loading

mlewand left a comment

msamsel commented Feb 5, 2018

mlewand left a comment

		@@ -1,5 +1,5 @@
		/**
		* @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.

Update main sample page with new CKEditor logo #1409

Update main sample page with new CKEditor logo #1409

Conversation

msamsel commented Jan 5, 2018

What is the purpose of this pull request?

Does your PR contain necessary tests?

This PR contains

What changes did you make?

mlewand left a comment

Choose a reason for hiding this comment

msamsel commented Jan 18, 2018

mlewand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msamsel commented Jan 30, 2018 • edited Loading

Choose a reason for hiding this comment

mlewand left a comment

Choose a reason for hiding this comment

msamsel commented Jan 31, 2018 • edited Loading

mlewand left a comment

Choose a reason for hiding this comment

msamsel commented Feb 5, 2018

mlewand left a comment

Choose a reason for hiding this comment

msamsel commented Jan 30, 2018 •

edited

Loading

msamsel commented Jan 31, 2018 •

edited

Loading