Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JAWS leaving forms mode after pressing enter in CKEditor inline instances #1780

Merged
merged 3 commits into from
Mar 12, 2018

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Mar 12, 2018

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

The reason why JAWS was leaving forms mode was that we're using [role="textbox"] but no [aria-multiline] attr.

After adding the latter the issue is gone.

Closes #1034.

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 8001a86 into next Mar 12, 2018
@Comandeer Comandeer deleted the t/1034 branch March 12, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants