Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration with CKFinder #1840

Merged
merged 18 commits into from
Mar 26, 2018
Merged

Fix integration with CKFinder #1840

merged 18 commits into from
Mar 26, 2018

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

If upload method is set to xhr and URL contains command=QuickUpload, then responseType=json URL parameter is added.

Closes #1835.

Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks OK, added minor corrections here and there. Propsed in #1841.

@mlewand mlewand self-requested a review March 26, 2018 14:57
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing again, I found an uncovered regression compared to form-based: in case of error the error message is not propagated to alert box. Instead it's replaced with a generic filetools error:

Current

Vague error about HTTP 400 status code

Original

Clear information that uploaded image was too big

Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants