Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced CKEDITOR.dom.nodeList#toArray method #752

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Introduced CKEDITOR.dom.nodeList#toArray method #752

merged 2 commits into from
Aug 9, 2017

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Aug 9, 2017 •
edited
Loading

What is the purpose of this pull request?

Task

This PR contains

  • Unit tests
  • Manual tests - skipped it's an API-only changed

What changes did you make?

Simply added new CKEDITOR.dom.nodeList#toArray method.

Closes #751.

@mlewand mlewand requested a review from f1ames August 9, 2017 10:02
f1ames
f1ames approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@f1ames f1ames merged commit 33c1409 into master Aug 9, 2017
@f1ames f1ames deleted the t/751 branch August 9, 2017 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1ames f1ames f1ames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlewand @f1ames