[#842] Fix for indention list troubles #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1ames
suggested changes
Sep 14, 2017
plugins/indentlist/plugin.js
Outdated
| @@ -174,7 +174,19 @@ | |||
| listArray[ i ].indent += indentOffset; | |||
| // Make sure the newly created sublist get a brand-new element of the same type. (http://dev.ckeditor.com/ticket/5372) | |||
| if ( indentOffset > 0 ) { | |||
| var listRoot = listArray[ i ].parent; | |||
| var listRoot; | |||
There was a problem hiding this comment.
While further in the code you are checking:
if ( listRoot === undefined ) {
listRoot = listArray[ i ].parent;
}
why not initialize var listRoot = listArray[ i ].parent; so it already has default value which alternatively will be overwritten inside the for loop.
plugins/indentlist/plugin.js
Outdated
| var listRoot = listArray[ i ].parent; | ||
| var listRoot; | ||
|
|
||
| for ( var j = i - 1; j >= 0; j-- ) { |
There was a problem hiding this comment.
Some comment with the issue reference could be useful here so it is clear what is the exact purpose of this loop.
|
|
||
| 1. Put caret in paragraph with `333`. | ||
| 1. Use `Decrease indent` to move paragraph to the left. | ||
| 1. Use `Increase indent` to move paragraph to the right. |
There was a problem hiding this comment.
I would go with:
Use
Decrease indentbutton to move list item to the right.
| 1. Use `Decrease indent` to move paragraph to the left. | ||
| 1. Use `Increase indent` to move paragraph to the right. | ||
|
|
||
| **Expected:** List item with `333` has circle as a list tag. |
There was a problem hiding this comment.
... has a circle as a list bullet.
| @@ -0,0 +1,14 @@ | |||
| @bender-tags: 4.7.3, 842, bug | |||
There was a problem hiding this comment.
Please update target version tag to 4.8.0.
added 3 commits
September 15, 2017 11:14
- little code optimization - adding code comments - typo and tag fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
close #842