Improve the horizontal drop target line. #14970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (theme-lark): Improve the drag and drop target line.
Closes #14645.
Additional information
One thing is not done - white outline for darken backgrounds.
CSS
outlines and box shadows wont work cause we're using two elements combinedtriangle
apseudo element
to imitate the arrow and the line (vertical or horizontal). Those CSS properties works on each of them - for example a shadow from the arrow covers the line.2nd approach was to use
filter: drop-shadow
and this solution was looking promising (Chrome):Screen.Recording.2023-09-07.at.15.37.25.mov
BUT it completely not working on Safari (i found that dragging elements with
filter: drop-shadow
issue is there for years):Screen.Recording.2023-09-07.at.15.36.18.mov
Using ASCII/Unicode signs as the arrows also wasn't working as expected.
Idea 💡
Maybe in future we can think about different solution/approach - get the background color of the editing area and based on this set some light/dark colors (it's different than the
prefers-color-scheme
). Simple example of what i have on my mind.