Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the horizontal drop target line. #14970

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

pszczesniak
Copy link
Contributor

Suggested merge commit message (convention)

Other (theme-lark): Improve the drag and drop target line.

Closes #14645.


Additional information

One thing is not done - white outline for darken backgrounds.

CSS outlines and box shadows wont work cause we're using two elements combined triangle a pseudo element to imitate the arrow and the line (vertical or horizontal). Those CSS properties works on each of them - for example a shadow from the arrow covers the line.

2nd approach was to use filter: drop-shadow and this solution was looking promising (Chrome):

Screen.Recording.2023-09-07.at.15.37.25.mov

BUT it completely not working on Safari (i found that dragging elements with filter: drop-shadow issue is there for years):

Screen.Recording.2023-09-07.at.15.36.18.mov

Using ASCII/Unicode signs as the arrows also wasn't working as expected.


Idea 💡

Maybe in future we can think about different solution/approach - get the background color of the editing area and based on this set some light/dark colors (it's different than the prefers-color-scheme). Simple example of what i have on my mind.

@Witoso
Copy link
Member

Witoso commented Sep 11, 2023

FYI @dagdzi, we needed to cut the white outline for now.

@arkflpc arkflpc merged commit 3ec29eb into master Sep 11, 2023
@arkflpc arkflpc deleted the ck/14645-drag-and-drop-improve-the-drop-target-line branch September 11, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drag & drop, intro] Improve the drop target line
3 participants