Update ansi_term to 0.12

[Eijebong]

No description provided.

[rivy]

This probably needs to wait until ogham/rust-ansi-term#52 lands to preserve windows compilation (likely requiring that vNEXT as well).

I'll ping @ogham about it.

[Razican]

I think this has landed in 0.12.1, so this should be ok if it's ran again (you should probably bump the version in Cargo.toml to 0.12.1, though, just in case.

[Razican]

The error happens because it now needs Rust 1.36 to be built, so this requires a bump in the minimum supported Rust version, from 1.33 to 1.36 in the Travis-CI configuration.

[kbknapp]

Although we could technically update to 1.36 (due to wanting to support stable minus two releases), are there some tangible gains for our use cases? I'm not against upgrading to 1.36 minimum, but want to weigh the options first.

[kbknapp]

v3-master just recently became master in prep for a beta release. This PR was autoclosed when the v3-master PR went away. Could you re-open against the master branch? Thanks!

[Razican]

Although we could technically update to 1.36 (due to wanting to support stable minus two releases), are there some tangible gains for our use cases? I'm not against upgrading to 1.36 minimum, but want to weigh the options first.

Well, it seems that this new version of ansi_term requires it, and updating removes the obsolete dependency, which I think is good enough, especially for crates using both ansi_term and clap, so that they don't need two versions of the same dependency.

[kbknapp]

See #1590 we're updating the MSRV to 1.36 so if you'd like to re-open this PR against master I think it'll be good.

[rivy]

Not to muddy the waters, but ansi-term is passing tests back to 1.28 (see https://ci.appveyor.com/project/ogham/rust-ansi-term/builds/27119388/job/m9ygtf90f0or7w6c).

The problem child looks to be toml. From toml v0.5.3 to toml v0.5.4, it looks like there was a code change requiring a new (much later) rust minimum version.

(Am I the only one who finds that "non-semantic" and irksome?)

[kbknapp]

Yeah it was toml that caused the update, however I've merged that clap v3.0-beta.1 requires a minimum of Rust 1.36 and thus can compile toml. This is still within the "stable minus two" policy. So this PR should be good now if you'd like to re-open it against master.

(Am I the only one who finds that "non-semantic" and irksome?)

Technically pre 1.0 releases have no semantic meaning. But yeah I do find it very irksome how reluctant Rust crates are to go to 1.0 and start following semver.

[rivy]

Ah, true, I forget about the semver 1.0 caveat.