Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): Make customizeing flags easier #4095

Merged
merged 2 commits into from
Aug 19, 2022
Merged

feat(parser): Make customizeing flags easier #4095

merged 2 commits into from
Aug 19, 2022

Commits on Aug 19, 2022

  1. fix(parser): Move TypedValueParsers constraint earlier in process

    @epage
    epage committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    19d436d View commit details
    Browse the repository at this point in the history

  2. feat(parser): Make customizeing flags easier 

    While `TypedValueParser` will generally make it easier to reuse value
parsers, this was particularly written for flags.  Besides having a
concrete API to document, an advantage over `fn(&str) -> Result<bool, E>`
value parsers is you get all of the benefits of the existing value
parsers for environment variable parsing.
    @epage
    epage committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    9074b60 View commit details
    Browse the repository at this point in the history