Added TryDomain instances to Clash sized types #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
force-pushed
the
TryDomain-clashtypes
branch
from
3c67427 to
cddc557
Compare
martijnbastiaan
approved these changes
Feb 11, 2022
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
(cherry picked from commit c51d0b9)
martijnbastiaan
pushed a commit
that referenced
this pull request
Feb 11, 2022
|
This PR also removes the TODO note. Was it checked that all applicable types were added now? |
|
I checked, I don't think there are more clash types which are missing. Please let me know if you noticed I missed some, |
|
Oh no my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See no reason to not have them.
Still TODO: