Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup go.mod #179

Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 15, 2023

Summary of changes

Cleans up go.mod in v0.45.13-proposal

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@faddat faddat mentioned this pull request Mar 15, 2023
8 tasks
@ZaradarBH ZaradarBH added out of scope work that is unapproved by the community, but still essential for the L1 team enhancement New feature or request discuss Still being debated labels Mar 16, 2023
@ZaradarBH
Copy link
Contributor

ZaradarBH commented Mar 17, 2023

This PR bumps to Go 1.20 which you have been told repeatedly not to do. It removes security replacements simply because you for refuse to listen and it seems to do stuff that is already being done in another PR. So overall this PR really makes no sense.

We can discuss your auto refactoring suggestions on the other PR and do whatever go.mod changes you feel is needed after we are done merging the 45.13 PR and done discussing your change requests @ #178.

@ZaradarBH ZaradarBH closed this Mar 17, 2023
@faddat
Copy link
Contributor Author

faddat commented Mar 18, 2023

Sir it did a hell of a lot more than that.

Now, you're still against either 1.19 and 1.20?

@ZaradarBH
Copy link
Contributor

You are not listening to what I am telling you and I do not have time to entertaining your adolescence Jacob. If you want to provide constructive feedback listen to what your being told, dont put words in peoples mouth. What your being told is that we will not be bumping to Go 1.19+ in 2.0 or 2.1. Accept it or not. That is largely irrelevant to us 🙏

@faddat
Copy link
Contributor Author

faddat commented Mar 18, 2023

that is correct Tobias, I am not listening to you when you say things that aren't valid.

The other members of the l1tf should also not blindly obey you, either.

(note for posterity: Notional is not a part of the L1TF. We left because we felt that Tobias was a danger to token holders.)

Around the time Notional left the L1TF, @nghuyenthevinh2000 left Notional, and subsequently joined the L1TF.

Seems to me he is doing good work, but being fed completely false information about software development by Tobias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Still being debated enhancement New feature or request out of scope work that is unapproved by the community, but still essential for the L1 team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants