Skip to content
This repository has been archived by the owner on Apr 22, 2019. It is now read-only.

Magento 2.2.0 Compatibility #85

Closed
lstellway opened this issue Sep 28, 2017 · 16 comments
Closed

Magento 2.2.0 Compatibility #85

lstellway opened this issue Sep 28, 2017 · 16 comments

Comments

@lstellway
Copy link

lstellway commented Sep 28, 2017

The most recent release of Magento 2 is version 2.2.0. The ClassyLlama AvaTax module has a defined dependency on magento/framework:^100.1.0, however Magento 2.2.0 requires magento/framework:101.0.0.

This dependency definition prevents upgrading a Magento 2 instance to the latest version.

@erikhansen
Copy link
Contributor

@loganstellway - See below. Please let us know the results of your testing, if you choose to proceed with installing this on 2.2.

@rsisco - As you know, we have an internal task to test compatibility with Magento 2.2. However until that's done, I think we should allow merchants to upgrade to 2.2.0 at their own risk. Can you:

  1. Edit the https://github.com/classyllama/ClassyLlama_AvaTax/blob/develop/composer.json file to allow the extension to be installed 2.1.x and 2.2.x. You may want to reference https://getcomposer.org/doc/articles/versions.md for how to best do this.
  2. Update the module's readme (https://github.com/classyllama/ClassyLlama_AvaTax#magento-version-support) to explicitly state that Magento 2.2.x has not been tested yet.

@franckgarnier21
Copy link

Any update or workaround for this Magento 2.2 upgrade ?

@lstellway lstellway mentioned this issue Oct 16, 2017
@lstellway
Copy link
Author

@franckgarnier21
I have created a pull request for the changes asked for by @erikhansen above.

@erikhansen / @rsisco
Can you please merge the changes or create a branch specifically for this issue?

Thanks!

@erikhansen
Copy link
Contributor

@rsisco Can you regard @loganstellway's comment today?

@rsisco
Copy link

rsisco commented Oct 17, 2017

@loganstellway - I've merged your PR (with a slight change to the ReadMe) into the develop branch.

To change your AvaTax installation to track with the develop branch, you should run:

composer require classyllama/module-avatax:dev-develop

@franckgarnier21
Copy link

Many thanks for your quick update

@lstellway
Copy link
Author

@rsisco
Thank you! I will be implementing this on a test environment in the near future. I will report back with any issues.

@erikhansen
Copy link
Contributor

@loganstellway How has your testing with 2.2 gone? Have you discovered any issues? We're going to start our 2.2 testing next week.

@JosephMaxwell
Copy link

@erikhansen: any update on when the 2.2 compatibility will be finalized?

@erikhansen
Copy link
Contributor

@JosephMaxwell We finished testing today and uncovered a few minor issues. We'll be working on resolution of those issues over the coming week and I hope we'll have it released by the end of next week.

@JosephMaxwell
Copy link

@erikhansen: thank you.

rsisco pushed a commit that referenced this issue Nov 25, 2017
- Refactor code to be fully compatible with Magento 2.2 while retaining
  backwards compatibility with 2.1
- Addresses Issue #85
@rsisco
Copy link

rsisco commented Nov 27, 2017

This is has been resolved as of release 1.2.3. Closing issue.

@rsisco rsisco closed this as completed Nov 27, 2017
@rsisco
Copy link

rsisco commented Nov 27, 2017

We've just identified a bug in release 1.2.3 that prevents DI compilation. We are quickly addressing the issue and will release a new version shortly with a fix.

@rsisco
Copy link

rsisco commented Nov 27, 2017

A new release has been published fixing the DI compilation issue. Closing issue.

@rsisco rsisco closed this as completed Nov 27, 2017
@almsmack
Copy link

almsmack commented Jan 3, 2018

Have you had a chance to make progress on this testing? Any projected timeframe for official Magento 2.2 compatibility?

@erikhansen
Copy link
Contributor

@almsmack The latest version of this extension supports 2.2.0. However that version has not yet made it on to the Marketplace, so you'll need to install it using one of the methods documented here: https://www.classyllama.com/documentation/extensions/avatax-magento-2-module#installation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants