fix: children elements in nested lists drag parent elements. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasztomys
suggested changes
Jan 23, 2017
| <Handle/> | ||
| <span>Category {props.value}</span> | ||
| </div> | ||
| <ListWrapper component={SortableList} className={style.categoryList} items={getItems(5, 59)} shouldUseDragHandle={true} helperClass={style.stylizedHelper} /> |
| @@ -143,6 +143,10 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f | |||
| } | |||
| }; | |||
|
|
|||
| nodeIsChild = node => { | |||
DeadHeadRussell
force-pushed
the
master
branch
from
9f0dc10
to
3549bbb
Compare
|
Hey @DeadHeadRussell, thank you so much for taking the time to submit this, and for even going the extra mile and writing a storybook demo for it ❤️ Should be released shortly, stay tuned! Edit: Just released |
|
No problem. Thanks for merging it so quickly! |
DimitarNestorov
pushed a commit
to codemotionapps/react-sortable-hoc
that referenced
this pull request
Feb 4, 2019
fix: children elements in nested lists drag parent elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a pull request for issue #112
This commit has both a fix, and also a new story for nested lists as a test case.