Add APX flag support #1621
Merged
Add APX flag support #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for new APX optimization level. Change increases the maximim potential optimization level but does not yet allow the files to be used (installed). get_opt_level_mask still needs to be updated to account for system supporting the new optimization level (and adding APX_SKIP_FILE support) before the APX files can be installed. This change is being done at this time to allow mixer to create these files without swupd error messages during updates. Signed-off-by: William Douglas <william.douglas@intel.com>
Generated with: openssl req -x509 -newkey rsa:4096 -out pemfile -sha256 -days 3650 \ -nodes -subj "/CN=localhost" Signed-off-by: William Douglas <william.douglas@intel.com>
fenrus75
reviewed
Jan 21, 2024
fenrus75
approved these changes
Jan 21, 2024
The error message about skipping unsupported file optimization levels only needs to be printed once so do that instead of potentially spamming it. Signed-off-by: William Douglas <william.douglas@intel.com>
fenrus75
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new APX optimization level. Change increases the maximim potential optimization level but does not yet allow the files to be used (installed). get_opt_level_mask still needs to be updated to account for system supporting the new optimization level (and adding APX_SKIP_FILE support) before the APX files can be installed.
This change is being done at this time to allow mixer to create these files without swupd error messages during updates.