Test fixups and update for newer systemd #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwarden So I'm inclined to merge this though the API detection change is real. The underlying systemctl command seems to have changed how it reports missing unit files so our reporting should update as well. That said, the test for running |
bwarden
reviewed
Jul 29, 2024
bwarden
reviewed
Jul 29, 2024
systemctl reports that the timer file is missing now as a return code 4 so update the unknown start number. Also with this change SWUPD_NO is no longer always returned so add a new helper to check if a status is one of multiple options. Signed-off-by: William Douglas <william.douglas@intel.com>
bryteise
force-pushed
the
more-test-fixups
branch
from
281d138
to
3306d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemctl reports that the timer file is missing now as a return code 4 so update the unknown start number.
Also with this change SWUPD_NO is no longer always returned so add a new helper to check if a status is one of multiple options.