Redirect URL override messages to STDERR #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwarden
force-pushed
the
fix-real_content-tests
branch
4 times, most recently
from
f91a1e8
to
294863a
Compare
bwarden
changed the title
bryteise
approved these changes
Aug 26, 2024
Previously, these messages were printed to STDOUT: Overriding version and content URLs with... Overriding content URL with... Overriding version URL with... But especially with --quiet, the output to STDOUT should be strictly the requested data. So print these as warnings instead.
Eliminate some uses of wc -l that don't help. Take advantage of lines
array to count bundles.
Separate STDERR messages from $output and ${lines[@]} that are used for
bundles.
bwarden
force-pushed
the
fix-real_content-tests
branch
from
294863a
to
3d21bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these messages were printed to STDOUT:
Overriding version and content URLs with...
Overriding content URL with...
Overriding version URL with...
But especially with --quiet, the output to STDOUT should be strictly the requested data. So print these as warnings instead.
Fix tests to match this change. Also eliminate some uses of wc -l that don't help. Take advantage of lines array to count bundles.