Change memory search to match by parts and case insensitive #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelTsengLZ @disulliv ready for review |
qtomlinson
force-pushed
the
qt/memory_search_by_parts
branch
from
0bba408 to
4c1cd38
Compare
The dev and production deployment uses AzureSearch, where search for pattern "npmjs/red" will return results including npm/npmjs/-/redis/0.1.0. In addition, the search is case insensitive. In comparison, memory search (typically used during local development) searches strictly for coordinates string containing "npmjs/red". Change to match by parts and case insensitive. This is to make memory search more consistent with AzureSearch.
qtomlinson
force-pushed
the
qt/memory_search_by_parts
branch
from
4c1cd38 to
1736292
Compare
MichaelTsengLZ
approved these changes
Jul 12, 2022
|
@qtomlinson Do you want me to merge this? |
|
@MichaelTsengLZ Yes, please! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev and production deployment uses AzureSearch, where search for
pattern "npmjs/red" will return results including npm/npmjs/-/redis/0.1.0.
In addition, the search is case insensitive.
In comparison, memory search (typically used during local development)
searches strictly for coordinates string containing "npmjs/red".
Change to match by parts and case insensitive. This is to make
memory search more consistent with AzureSearch.