Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear division of roles of joinsplit_gadget and circuit_wrapper #290

Open
dtebbs opened this issue Sep 28, 2020 · 0 comments
Open

Clear division of roles of joinsplit_gadget and circuit_wrapper #290

dtebbs opened this issue Sep 28, 2020 · 0 comments
Labels
arithmetic-circuit/R1CS Task related to the R1CS programs c++ Task related to the c++ part of the code base code-quality Task related to the code quality (refactor, enhancements etc.)

Comments

@dtebbs
Copy link
Contributor

dtebbs commented Sep 28, 2020

It may be valuable to move the allocation of circuit inputs and the specification of the number of public inputs out of the gadget into the circuit_wrapper class. This is in order to:

  • be consistent with other gadgets
  • maintain better separation of concerns
  • support reuse of joinsplit_gadget in other circuits (e.g. in the case of a single public input which is the hash of the joinsplit inputs)

(clearmatics/zecale#39 (comment))

@AntoineRondelet AntoineRondelet added arithmetic-circuit/R1CS Task related to the R1CS programs c++ Task related to the c++ part of the code base code-quality Task related to the code quality (refactor, enhancements etc.) labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arithmetic-circuit/R1CS Task related to the R1CS programs c++ Task related to the c++ part of the code base code-quality Task related to the code quality (refactor, enhancements etc.)
Projects
None yet
Development

No branches or pull requests

2 participants