Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use socketpair() to create sockets #425

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Jul 8, 2021

Simplifies sockethelpers.cpp, removes the need to place files in the file system, and might make libTAS less likely to break when running multiple instances at the same time.

Possible cons:

  • Might break things if an application closes unrecognised file descriptors for no reason
    • Neither wine, nor gdb does this so it should be fine

Supersedes #420.

@jakobrs jakobrs marked this pull request as draft July 17, 2021 18:55
@jakobrs
Copy link
Contributor Author

jakobrs commented Jul 17, 2021

Want to figure out how to get this to work with lldb, which closes all fds except 0, 1, and 2 by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant