From 0a7a889956f5e060584b17cdb59d9c9abe5473f9 Mon Sep 17 00:00:00 2001
From: George Desipris <73396808+desiprisg@users.noreply.github.com>
Date: Wed, 12 Jul 2023 16:47:27 +0300
Subject: [PATCH] fix(clerk-js): Remove leftover strings in SignInStart and
 SignUpStart

---
 .changeset/fifty-keys-burn.md                          |  5 +++++
 .../clerk-js/src/ui/components/SignIn/SignInStart.tsx  | 10 +++-------
 .../clerk-js/src/ui/components/SignUp/SignUpStart.tsx  | 10 +++-------
 3 files changed, 11 insertions(+), 14 deletions(-)
 create mode 100644 .changeset/fifty-keys-burn.md

diff --git a/.changeset/fifty-keys-burn.md b/.changeset/fifty-keys-burn.md
new file mode 100644
index 00000000000..57ed952921e
--- /dev/null
+++ b/.changeset/fifty-keys-burn.md
@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-js': patch
+---
+
+Fixed a bug where overriding some localization values in the sign in/up start pages with an empty string would result in showing the english translation.
diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
index 3b4f6d380c6..865239bab18 100644
--- a/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
+++ b/packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
@@ -278,22 +278,18 @@ export function _SignInStart(): JSX.Element {
                   />
                 </Form.ControlRow>
                 <InstantPasswordRow field={passwordBasedInstance ? instantPasswordField : undefined} />
-                <Form.SubmitButton>Continue</Form.SubmitButton>
+                <Form.SubmitButton />
               </Form.Root>
             ) : null}
           </SocialButtonsReversibleContainerWithDivider>
         </Col>
         <Footer.Root>
           <Footer.Action elementId='signIn'>
-            <Footer.ActionText localizationKey={localizationKeys('signIn.start.actionText')}>
-              No account?
-            </Footer.ActionText>
+            <Footer.ActionText localizationKey={localizationKeys('signIn.start.actionText')} />
             <Footer.ActionLink
               localizationKey={localizationKeys('signIn.start.actionLink')}
               to={clerk.buildUrlWithAuth(signUpUrl)}
-            >
-              Sign up
-            </Footer.ActionLink>
+            />
           </Footer.Action>
           <Footer.Links />
         </Footer.Root>
diff --git a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
index 830ca3b2d78..c5da5c6cd1a 100644
--- a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
+++ b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
@@ -240,10 +240,8 @@ function _SignUpStart(): JSX.Element {
       <Card>
         <CardAlert>{card.error}</CardAlert>
         <Header.Root>
-          <Header.Title localizationKey={localizationKeys('signUp.start.title')}>Create your account</Header.Title>
-          <Header.Subtitle localizationKey={localizationKeys('signUp.start.subtitle')}>
-            to continue to {displayConfig.applicationName}
-          </Header.Subtitle>
+          <Header.Title localizationKey={localizationKeys('signUp.start.title')} />
+          <Header.Subtitle localizationKey={localizationKeys('signUp.start.subtitle')} />
         </Header.Root>
         <Flex
           direction='col'
@@ -271,9 +269,7 @@ function _SignUpStart(): JSX.Element {
         </Flex>
         <Footer.Root>
           <Footer.Action elementId='signUp'>
-            <Footer.ActionText localizationKey={localizationKeys('signUp.start.actionText')}>
-              Have an account?
-            </Footer.ActionText>
+            <Footer.ActionText localizationKey={localizationKeys('signUp.start.actionText')} />
             <Footer.ActionLink
               localizationKey={localizationKeys('signUp.start.actionLink')}
               to={clerk.buildUrlWithAuth(signInUrl)}