Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the possibility to esplora to configure the URL if it is a default URL #77

Open
vincenzopalazzo opened this issue Nov 6, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@vincenzopalazzo
Copy link
Member

vincenzopalazzo commented Nov 6, 2020

The last version of esplora plugin (v 0.1) gives the possibility to configure the correct URL with the lightnind configuration.

This issue is a propose to add some configuration extra to Lamp settings to set up a personal endpoint or use the default endpoints

@vincenzopalazzo vincenzopalazzo added the enhancement New feature or request label Nov 6, 2020
@vincenzopalazzo vincenzopalazzo self-assigned this Nov 6, 2020
@darosior
Copy link
Contributor

darosior commented Nov 7, 2020

I've been using a custom endpoint for some time now ?

@vincenzopalazzo
Copy link
Member Author

Hello @darosior, If you specified your custom URL yes. But maybe my issue explanation is a little unclear.
I mean that the esplora plugin now is able to set up the correct URL (tor url or a normal https url) from the lightnind network configuration, this makes easy choose to use a different URL inside the android app without setting up the URL from setting (e.g. if you are using a proxy maybe you want to use the tor URL). However, this is not possible with a lamp at the moment because it forces the esplora plugin to set up a URL expressed inside the setting, so if you want to use the tor url you need to copy and paste the URL from the web to the app or typing it :-).

I would like to support inside the setting the option to enable the custom URL if someone is running esplora in her own server, but I want also that if the user wants to use the default esplora URL, don't need to specified nothings and at the same time I would like to manage the choose of URL under the hood with esplora plugin and lightnind.

What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants