new middleware op to tap-current-value

[behrica]

In order to continue to support:
clojure-emacs/cider#3311

I think we need a new middleware function, which could the be called later from the cider inspect elisp code to be written.

I think it should be very similar to this function

cider-nrepl/src/cider/nrepl/middleware/inspect.clj

Line 105 in d219ce6

(defn def-current-value [msg]

and call the new function in orchard inspect/tap-current-value
introduced with commit: clojure-emacs/orchard@625a78a

Does this seems reasonable to go ahead in supporting clojure-emacs/cider#3311 ?

[behrica]

Would you be interested in a PR for this ?

[vemv]

Yes!

Cheers - V

[behrica]

I tried to figure out, how I can test my new middleware op without corresponding elisp functions.

I managed to do this:

(with-open [conn (nrepl/connect :port 42857)]
     (-> (nrepl/client conn 1000)    ; message receive timeout required
         (nrepl/message {:op "eval" :code "(+ 2 3)"})
         nrepl/response-values))

How can I use the inspector middleware in this way ?
Are there any prerequisites (middleware ops to be called to "init" the inspector ) ?
Something like this (with an existing op, does not work):

(with-open [conn (nrepl/connect :port 42857)]
     (-> (nrepl/client conn 1000)    ; message receive timeout required
         (nrepl/message {:op "inspect-def-current-value" :ns "user" :var-name "test-xxx"})
         ))

I suppose I need to call som middleware ops before this ?
I looked at the documentation of all midleware ops:
https://docs.cider.mx/cider-nrepl/nrepl-api/ops.html

but did not see anything which looked like "starting the inspector"

[behrica]

Otherwise asked:

Which middleware op(s) do I need to call, so that a following op
inspect-def-current-value would have a notion of "current value" ?

[behrica]

Knowing this, I could then test my op: inspect-tap-current-value

[vemv]

Hey @behrica, sorry for the delay.

For developing this feature, I would suggest:

• Draft your middleware in the cider-nrepl repo
• Install it with lein with-profile plugin.mranderson/config install
• Start a CIDER session, make sure the inspector works as usual
• Read the cider-inspector.el source
  • Specifically, all the code that invokes cider-nrepl-send-sync-request
  • Remember, you can redefine this code to add printlns, etc - anything that would help your understanding
  • Also *nrepl-log* will tell you the specific trail of nrepl interactions that a given feature entails.
• Start sending messages to your middleware
• Refine things, and recur!

The key idea is that you simple use CIDER to develop CIDER, instead of emulating an interaction with Clojure nrepl code.

(...That is of course possible but may be hard if you aren't already familiar with the inspector. IDK)

Hope it helps!

[behrica]

I did as you suggested and did both small changes to cider-nrepl and cider at the same time localy and verified that it works.
I will do a PR first here.