Skip to content

Commit d84b8a8

Browse files
ustunbbatsov
authored andcommitted
Update various faces when a theme is disabled
Previously, we were only updating faces when we enable themes.
1 parent ea23329 commit d84b8a8

File tree

4 files changed

+16
-0
lines changed

4 files changed

+16
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
### Bugs Fixed
3131

32+
* [#1987](https://github.com/clojure-emacs/cider/issues/1987): Fix: Update faces when disabling a theme
3233
* [#1962](https://github.com/clojure-emacs/cider/issues/1962): Fix performance in fringe overlay placement.
3334
* [#1947](https://github.com/clojure-emacs/cider/issues/1947): Fix error on `cider-jack-in` when `enlighten-mode` is enabled.
3435
* [#1588](https://github.com/clojure-emacs/cider/issues/1588): Redirect `*err*`, `java.lang.System/out`, and `java.lang.System/err` to REPL buffer on all attached sessions.

cider-doc.el

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,11 @@
135135
"When theme is changed, update `cider-docview-code-background-color'."
136136
(setq cider-docview-code-background-color (cider-scale-background-color)))
137137

138+
139+
(defadvice disable-theme (after cider-docview-adapt-to-theme activate)
140+
"When theme is disabled, update `cider-docview-code-background-color'."
141+
(setq cider-docview-code-background-color (cider-scale-background-color)))
142+
138143

139144
;; Mode & key bindings
140145

cider-stacktrace.el

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ The error types are represented as strings."
175175
(setq cider-stacktrace-frames-background-color (cider-scale-background-color)))
176176

177177

178+
(defadvice disable-theme (after cider-stacktrace-adapt-to-theme activate)
179+
"When theme is disabled, update `cider-stacktrace-frames-background-color'."
180+
(setq cider-stacktrace-frames-background-color (cider-scale-background-color)))
181+
182+
178183
;; Mode & key bindings
179184

180185
(defvar cider-stacktrace-mode-map

cider-test.el

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,11 @@ Add to this list to have CIDER recognize additional test defining macros."
122122
(setq cider-test-items-background-color (cider-scale-background-color)))
123123

124124

125+
(defadvice disable-theme (after cider-test-adapt-to-theme activate)
126+
"When theme is disabled, update `cider-test-items-background-color'."
127+
(setq cider-test-items-background-color (cider-scale-background-color)))
128+
129+
125130
;;; Report mode & key bindings
126131
;; The primary mode of interacting with test results is the report buffer, which
127132
;; allows navigation among tests, jumping to test definitions, expected/actual

0 commit comments

Comments
 (0)