Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default indents for time, delay #524

Closed
vemv opened this issue Apr 23, 2019 · 7 comments
Closed

Default indents for time, delay #524

vemv opened this issue Apr 23, 2019 · 7 comments

Comments

@vemv
Copy link
Member

vemv commented Apr 23, 2019

Shouldn't time and delay be indented with 2 spaces rather than 1?

As I view it, both macros take zero special arguments.

@bbatsov
Copy link
Member

bbatsov commented Apr 24, 2019

I don't see any special indentation rules for them in the code, so they should be indented just like any other form.

@vemv
Copy link
Member Author

vemv commented Apr 24, 2019

I don't see any special indentation rules for them in the code

Sorry, in which code?

@bbatsov
Copy link
Member

bbatsov commented Apr 24, 2019 via email

@vemv
Copy link
Member Author

vemv commented Apr 24, 2019

Yes, I didn't find rules for them and was thinking that they're missing, perhaps because those macros aren't used that much.

Otherwise it'd surprise me the different indentation style vs. most other clojure.core macros.

@bbatsov
Copy link
Member

bbatsov commented Apr 25, 2019

Got. Seems that delay takes a list of forms and probably deserves special indentation. For time I'm not so sure as it takes just a single form.

@Malabarba
Copy link
Member

I agree with Bozhidar. Even though time is a macro, it's used essentially as a function, so it's argument isn't really a body of forms.

@Malabarba
Copy link
Member

Yes, I didn't find rules for them and was thinking that they're missing, perhaps because those macros aren't used that much.

Probably, yes. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants