Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the GITHUB_TOKEN with a PAT #1072

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

yunkon-kim
Copy link
Member

This PR will replace secret.GITHUB_TOKEN with secret.CB_GITHUB_ROBOT_PAT.

(Summary)

  • The GITHUB_TOKEN is scoped to the current repository (i.e., forked repo).
  • The GITHUB_TOKEN does NOT have permission to add comments on PRs opened in the upstream repo from the forked repo.
  • On the other hand, CB_GITHUB_ROBOT_PAT can be scoped as desired (repo scope is assigned)
  • Therefore, comments can be added on the PR with CB_GITHUB_ROBOT_PAT.

Ref: https://github.com/actions/github-script?tab=readme-ov-file#using-a-separate-github-token

In my opinion, this PR should be merged as is. And then, we can check for permission issues in the next PR.

(Until then, I'd like to keep #1070 open.)

@powerkimhub powerkimhub merged commit 6be2f10 into cloud-barista:master Feb 14, 2024
1 check passed
@yunkon-kim yunkon-kim deleted the yunkon-kim-240214-2 branch February 20, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants