Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS PriceInfo reset ProductFamily and add NextToken logic #1082

Merged

Conversation

SungWoongz
Copy link
Contributor

AWS 드라이버 특이사항

  • 기존 ProductFamily : AmazonEC2 → CPU Credits ~ System Operation 변경
  • 기존 NextToken 인자 값 고려 X → NextToken 값이 있다면 세팅 후 다음 상품 정보 조회

ListProductFamily

  • ProductFamily 변경
  • ProductFamily 목록
    "productFamily": "CPU Credits",
    "productFamily": "Compute Instance (bare metal)",
    "productFamily": "Compute Instance",
    "productFamily": "Dedicated Host",
    "productFamily": "EBS direct API Requests",
    "productFamily": "Elastic Graphics",
    "productFamily": "Fast Snapshot Restore",
    "productFamily": "Fee",
    "productFamily": "Load Balancer",
    "productFamily": "Load Balancer-Application",
    "productFamily": "Load Balancer-Network",
    "productFamily": "NAT Gateway",
    "productFamily": "Provisioned Throughput",
    "productFamily": "Storage Snapshot",
    "productFamily": "Storage",
    "productFamily": "System Operation",

GetPriceInfo

  • ServiceCode → AmazonEC2 고정

  • Filter 조건으로 ProductFamily 설정

  • NextToken

    • product 조회 시 NextToken값 세팅 x → 결과 목록 100개 출력
    • NextToken값이 있다면 값 설정 후 loop반복
    • NextToken값이 없어질 때 까지 loop 반복

AWS Driver Details

  • Existing ProductFamily : AmazonEC2 → CPU Credits ~ System Operation
  • Consider the existing NextToken factor value X → NextToken value, if any, set up and look up the next product information

ListProductFamily

  • ProductFamily Reset
  • ProductFamily Lists
    "productFamily": "CPU Credits",
    "productFamily": "Compute Instance (bare metal)",
    "productFamily": "Compute Instance",
    "productFamily": "Dedicated Host",
    "productFamily": "EBS direct API Requests",
    "productFamily": "Elastic Graphics",
    "productFamily": "Fast Snapshot Restore",
    "productFamily": "Fee",
    "productFamily": "Load Balancer",
    "productFamily": "Load Balancer-Application",
    "productFamily": "Load Balancer-Network",
    "productFamily": "NAT Gateway",
    "productFamily": "Provisioned Throughput",
    "productFamily": "Storage Snapshot",
    "productFamily": "Storage",
    "productFamily": "System Operation",

GetPriceInfo

  • ServiceCode → AmazonEC2 fixation

  • Set ProductFamily as Filter condition

  • NextToken

    • NextToken value setting x → output 100 results list when looking up product
    • If there is a NextToken value, set the value and repeat loop
    • Repeat loop until NextToken value disappears

@powerkimhub powerkimhub self-requested a review February 20, 2024 02:29
@powerkimhub powerkimhub linked an issue Feb 20, 2024 that may be closed by this pull request
@powerkimhub
Copy link
Member

  • Holding this PR until AdminWeb has been Tested

@powerkimhub powerkimhub merged commit b469907 into cloud-barista:master Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS:PriceInfo] InvalidParameterException
2 participants