Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tencent] Remove storage ProductFamily and add SPOTPAID missing #1100

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

SungWoongz
Copy link
Contributor

@SungWoongz SungWoongz commented Feb 28, 2024

Tencent 드라이버 특이사항

Related Issue - #1090

[GerPriceInfo]

  1. Price 조회 결과 개수 확인
  • 236개 규모 확인 → O
  • 총 pricing policy개수 : 610개이지만 중복 price가 374로 확인 610-374 = 236
  • 236개의 규모 O
  • 텐센트 클라우드에서는 각각의 pricing policy로 보지만 spider의 price는 인스턴스 타입별로 묶이기 때문

image

  • Policy - SPOTPAID가 누락되어 수정
  • Price조회 결과에서 POSTPAID, SPOTPAID 값이 정상적으로 인식되지 않아 결과값에서 누락됨
  • 처리완료
    • POSTPAID → cvm.ItemPrice 객체 반환
    • SPOTPAID → *cvm.ItenPrice 포인터 반환
  1. Price 조회 결과 목록 수정
  • ProductFamily - Storage 관련 Product Info값 제거

image

[기타]

  • log level 수정 : error 가 아닌 부분 → cblogger.Debug()

[GerPriceInfo]

  1. Check the number of Price lookup results
  • 236 Size Check → O
  • Total number of pricing policies: 610 but duplicate price is 374 confirmed 610-374 = 236
  • 236 magnitude O
  • In Tencent Cloud, each pricing policy is viewed, but the price of spider is grouped by instance type

image

  • Policy - fix due to missing SPOTPAID during verification
  • Missing due to different return value
  • POSTPAID → cvm.ItemPrice object return
  • SPOTPAID → *cvm.ItemPrice pointer return
  1. Modify Price Lookup Results List
    • ProductFamily - Delete Storage Product Info

image

[Other]

  • Modify log level: non-error part → cblogger.Debug()

Copy link

Good news! All print and log statements are in English, as per our guidelines. 😊

@powerkimhub powerkimhub self-requested a review February 28, 2024 11:02
@powerkimhub
Copy link
Member

@SungWoongz

  • 쉽고 상세한 설명 캄사합니다~
  • 이해가 쏙~ 되었습니다.

@powerkimhub powerkimhub merged commit 8a0a479 into cloud-barista:master Feb 28, 2024
2 checks passed
@powerkimhub powerkimhub linked an issue Feb 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tencent:PriceInfo] 2nd Test Results and Issue
2 participants