Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for node group length and support KeyPair IID label in GCP cluster handler. #1300

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

MZC-CSC
Copy link
Contributor

@MZC-CSC MZC-CSC commented Aug 26, 2024

related issue: #1252

작업 내용

  • gcp cluster handler 에서 node pool convert 시, node pool 에 등록되는 label 로 keypair iid 제공
  • type 2 ( cluster 생성 시 node group 을 같이 생성) 만 지원

작업 상세

  • cluster 조회의 경우 cluster node pool 에 적용된 keypair tag 를 조회하여 적절한 keypair iid 매핑
  • node group list 의 길이가 0보다 큰 경우에만 cluster 생성 가능 하도록 validation 추가
  • 적절한 log format 과 level 로 수정

hippo-an and others added 4 commits August 20, 2024 10:51
container operation's progress is not an int value like compute operation's progress.
gcp cluster handler - add keypair iid to node info
@MZC-CSC MZC-CSC requested a review from powerkimhub August 26, 2024 00:20
@powerkimhub powerkimhub merged commit dab8b06 into cloud-barista:master Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP:PMKS] after creating a cluster, I got an error with 'SystemId: does not exist' when getting it
3 participants